Skip to content

[WIP] Add support for helm-legacy track mode for Helm v4 compatibility#2467

Closed
yxxhero with Copilot wants to merge 1 commit into
feat/helm-legacy-track-modefrom
copilot/sub-pr-2466
Closed

[WIP] Add support for helm-legacy track mode for Helm v4 compatibility#2467
yxxhero with Copilot wants to merge 1 commit into
feat/helm-legacy-track-modefrom
copilot/sub-pr-2466

Conversation

Copilot AI commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Thanks for the feedback on #2466. I've created this new PR, which merges into #2466, to address your comment. I will work on the changes and keep this PR's description up to date as I make progress.

Original PR: #2466
Triggering comment (#2466 (comment)):

✅ Addressed Copilot Review Feedback

Thank you @copilot for the thorough review! I've addressed all three comments:

1. ✅ Added nil check for logger (Line 227 in pkg/state/helmx.go)

Added guard to prevent panic when logger is nil:

if st.logger != nil {
    st.logger.Warnf("trackMode 'helm-legacy' requires Helm v4, falling back to regular --wait for release %s", release.Name)
}

2. ✅ Used TrackMode constants instead of raw strings

Refactored to use kubedog.TrackMode* constants throughout:

  • string(kubedog.TrackModeKubedog) instead of "kubedog"
  • string(kubedog.TrackModeHelm) instead of "helm"
  • string(kubedog.TrackModeHelmLegacy) instead of "helm-legacy"

3. ✅ Fixed documentation formatting

Fixed the extra leading space and capitalized the sentence in line 103:

  • Before: settrackMode: helm-legacy:
  • After: To use this mode, set trackMode: helm-legacy:

All tests pass and make check succeeds! 🎉


🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants