Skip to content

Helmfile doesnt error if helm-secrets fail #1563

Description

@reimerp

Operating system

Ubuntu 24.04

Helmfile Version

0.165.0

Helm Version

v3.14.4

Bug description

Its an rather old issue (see link) but still open.
I use helm secrets Plugin and vals with hashicorp vault urls.
If the URL is incorrect and the secret isn't found, helmfile however renders ok or fails when the yaml is invalid and the yaml to json conversion fails.

All tools (helm / vals / helm secrets) report invalid secrets as an error and I also checked the correct returncode (0: ok / 1: not found)

Example helmfile.yaml

just use a secret url in a values file, eg:
value: ref+vault://an/invalid/vault/secret

Error message you've seen (if any)

No error. The missing secret renders to an empty string.
An error is expected though.

Steps to reproduce

demo is https://github.com/reimerp/vault-fragment-issue

Working Helmfile Version

no working

Relevant discussion

roboll/helmfile#1163

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions