Conversation
Contributor
Author
|
@cpanato Could you please review this PR when you have time? |
cpanato
requested changes
Apr 24, 2025
Member
cpanato
left a comment
cpanato
left a comment
There was a problem hiding this comment.
thanks fro working ont his some comments
Signed-off-by: Walthier David <[email protected]>
Contributor
Author
|
@cpanato Would you give it another glance please? I corrected the things you mentioned |
cpanato
approved these changes
Jun 2, 2025
|
Hi, is there a release contains this PR or i must use d4887be ? |
Contributor
Author
|
Hello! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the custom
cloud_provideroption to enable a LoadBalancer along with start of the cluster.This change enables the installation of an additional
cloud-provider-kindcomponent when the option is activated.Services requiring a LoadBalancer will now function as expected.