Conversation
Member
|
please sign the dco |
Contributor
Author
@cpanato Done ✔️ |
Contributor
Author
|
Hey @cpanato, are there any other blockers for proceeding with this change? |
Member
|
apolagizes just saw the notification now seems the job did not trigger can you try an amend and push again? |
This patch extends the installation of the kubectl binary to validate the checksum of the downloaded file, similar to what is already done for kind. This approach is also described as an optional step on https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-kubectl-binary-with-curl-on-linux. Signed-off-by: Felix Kästner <[email protected]>
Contributor
Author
|
@cpanato I think you need to manually approve the workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch extends the installation of the kubectl binary to validate the checksum of the downloaded file, similar to what is already done for kind. This approach is also described as an optional step on https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#install-kubectl-binary-with-curl-on-linux.