Skip to content

feat: add custom kubeconfig option as action input#119

Merged
cpanato merged 1 commit intohelm:mainfrom
jbattiato:main
Sep 30, 2024
Merged

feat: add custom kubeconfig option as action input#119
cpanato merged 1 commit intohelm:mainfrom
jbattiato:main

Conversation

@jbattiato
Copy link
Copy Markdown
Contributor

@jbattiato jbattiato commented Sep 27, 2024

Adding the custom kubeconfig option to pass it as an action input allows anyone to specify a certain KUBECONFIG environment variable to be used along the entire workflow job.

E.G.: I had to create a kind cluster to run some commands. This command requires the $KUBECONFIG to contain the actual kubernetes config path. With this patch I'm allowed to export the variable required to the next steps with certainty that I'm using the right kubernetes config.

Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

thanks

@cpanato cpanato merged commit 5d66646 into helm:main Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants