Skip to content

feat: options to configure local registry#113

Merged
cpanato merged 4 commits intohelm:mainfrom
tthvo:local-registry
Dec 18, 2024
Merged

feat: options to configure local registry#113
cpanato merged 4 commits intohelm:mainfrom
tthvo:local-registry

Conversation

@tthvo
Copy link
Copy Markdown
Contributor

@tthvo tthvo commented May 9, 2024 •
edited
Loading

Fixes #76

Description

Add options to configure an insecure local registry. An example workflow file can be:

name: Create Cluster with Registry

on: pull_request

jobs:
  create-cluster-with-registry:
    runs-on: ubuntu-latest
    steps:
      - name: Kubernetes KinD Cluster
        uses: helm/kind-action@v1
        with:
          registry: true
          registry_name: my-registry
          registry_port: 5001
          registry_enable_delete: true

Does this look alright?

Credits: Thanks https://github.com/container-tools/kind-action for providing the inspiration.

@tthvo tthvo force-pushed the local-registry branch 2 times, most recently from 12cb1e9 to becd144 Compare May 10, 2024 20:32
@cpanato cpanato requested a review from davidkarlsen May 13, 2024 08:25
cpanato
cpanato reviewed May 13, 2024
View reviewed changes
cpanato
cpanato requested changes May 13, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok, just need to revisit the local registry env var to follow github actions best practices

@tthvo tthvo force-pushed the local-registry branch from af844df to bb2ab6a Compare May 13, 2024 08:46
@tthvo tthvo force-pushed the local-registry branch from e79e8c4 to dfb7fe8 Compare June 6, 2024 09:48
@tthvo
Copy link
Copy Markdown
Contributor Author

tthvo commented Nov 19, 2024

Hi @cpanato @davidkarlsen, any further comments?

@cpanato
Copy link
Copy Markdown
Member

cpanato commented Dec 17, 2024

seems good
@tthvo can you please rebase and fix the conflicts then we can get this merged?

@tthvo
Copy link
Copy Markdown
Contributor Author

tthvo commented Dec 18, 2024

Rebased now. Thanks!

cpanato
cpanato approved these changes Dec 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

lets merge and test in the main branch

@cpanato cpanato merged commit 9315f6b into helm:main Dec 18, 2024
@EmilTholin EmilTholin mentioned this pull request Dec 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpanato cpanato cpanato approved these changes

@davidkarlsen davidkarlsen Awaiting requested review from davidkarlsen

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature request: local registry

2 participants

@tthvo @cpanato