Merged
Conversation
helm-bot
added
the
size/L
jdolitsky
approved these changes
Jun 4, 2020
8 tasks
bacongobbler
requested changes
Jun 5, 2020
3 tasks
pmengelbert
force-pushed
the
manifest-digest
branch
from
ca370d0 to
18df50b
Compare
bacongobbler
requested changes
Jun 23, 2020
pmengelbert
force-pushed
the
manifest-digest
branch
from
18df50b to
fb7c5d3
Compare
Currently, whenever the chart is printed, the digest of the .tar.gz content layer is printed as the digest. The manifest digest is important for OCI purposes, particularly in pushing to a registry. Resolves helm#8248. Signed-off-by: Peter Engelbert <[email protected]>
pmengelbert
force-pushed
the
manifest-digest
branch
from
fb7c5d3 to
30322d4
Compare
helm-bot
added
size/XS
Contributor
Author
|
@bacongobbler This PR has been rebased onto master, and no longer depends on PR #8216. We are looking into that PR separately, but this should be good to merge. |
hickeyma
added
the
needs-pick
vladfr
pushed a commit
to vladfr/helm
that referenced
this pull request
Sep 30, 2020
Currently, whenever the chart is printed, the digest of the .tar.gz content layer is printed as the digest. The manifest digest is important for OCI purposes, particularly in pushing to a registry. Resolves helm#8248. Signed-off-by: Peter Engelbert <[email protected]>
marckhouzam
removed
the
needs-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Determine chart digest by manifest
Currently, whenever the chart is printed, the digest of the .tar.gz
content layer is printed as the digest. The manifest digest is important
for OCI purposes, particularly in pushing to a registry.
Resolves #8248
If applicable: