Skip to content

Port PR #4161 to Helmv3 - Fix incorrect timestamp when helm package#7272

Merged
bacongobbler merged 1 commit intohelm:masterfrom
Hiruma31:bugfix/7220
Dec 19, 2019
Merged

Port PR #4161 to Helmv3 - Fix incorrect timestamp when helm package#7272
bacongobbler merged 1 commit intohelm:masterfrom
Hiruma31:bugfix/7220

Conversation

@Hiruma31
Copy link
Contributor

@Hiruma31 Hiruma31 commented Dec 19, 2019

Source: 96a85a0

@helm-bot helm-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 19, 2019
@Hiruma31 Hiruma31 mentioned this pull request Dec 19, 2019
Closed
@bacongobbler
Copy link
Member

bacongobbler commented Dec 19, 2019

closes #7220

@bacongobbler
Copy link
Member

bacongobbler commented Dec 19, 2019

would you mind fixing the failing tests?

GO111MODULE=on golangci-lint run
pkg/chartutil/save.go:211: File is not `gofmt`-ed with `-s` (gofmt)
		Name: name,
		Mode: 0644,
		Size: int64(len(body)),
pkg/chartutil/save_test.go:20: File is not `gofmt`-ed with `-s` (gofmt)
	"bytes"
make: *** [Makefile:85: test-style] Error 1

Exited with code exit status 2

@Hiruma31
Copy link
Contributor Author

Hiruma31 commented Dec 19, 2019 •
edited
Loading

@bacongobbler Yep already on it, probably an indent issue considering my environment.
CRLF FTW...

@bacongobbler bacongobbler added this to the 3.1.0 milestone Dec 19, 2019
@bacongobbler bacongobbler merged commit d876daa into helm:master Dec 19, 2019
@mattfarina mattfarina modified the milestones: 3.1.0, 3.0.3 Jan 28, 2020
@mattfarina mattfarina added needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. labels Jan 28, 2020
@baijum baijum mentioned this pull request May 26, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bacongobbler bacongobbler bacongobbler approved these changes

Assignees

No one assigned

Labels

needs-pick Indicates that a PR needs to be cherry-picked into the next release candidate. picked Indicates that a PR has been cherry-picked into the next release candidate. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

3.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@Hiruma31 @bacongobbler @mattfarina @helm-bot