pkg/kube: remove legacy import comments from test files#31932
Merged
gjenkins8 merged 1 commit intoMar 12, 2026
Conversation
Remove pre-Go modules import path comments from pkg/kube test files (ready_test.go, resource_test.go, statuswait_test.go) for consistency with the rest of the package. Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: Terry Howe <[email protected]>
pull-request-size
Bot
added
the
size/XS
Contributor
There was a problem hiding this comment.
Pull request overview
Removes legacy pre-Go-modules import path comments from remaining pkg/kube test files to align with the rest of the package and avoid tooling inconsistencies.
Changes:
- Remove
// import "helm.sh/helm/v4/pkg/kube"import path comments frompkg/kube*_test.gofiles. - Standardize test file
package kubedeclarations to match module-based builds.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/kube/statuswait_test.go | Drops legacy import path comment from the package declaration. |
| pkg/kube/resource_test.go | Drops legacy import path comment from the package declaration. |
| pkg/kube/ready_test.go | Drops legacy import path comment from the package declaration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhay1999
added a commit
to abhay1999/helm
that referenced
this pull request
Mar 12, 2026
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`) are obsolete since Go 1.11 where go.mod is the authoritative module path. These stale comments cause issues with downstream tooling such as Kythe. Removes the legacy import comments from 64 files across 20 packages: - cmd/helm - internal/chart/v3/lint and sub-packages - internal/plugin and sub-packages - internal/release/v2/util - pkg/chart/v2/lint and sub-packages - pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance - pkg/registry - pkg/release/v1/util - pkg/repo/v1 - pkg/storage and pkg/storage/driver Follows up on helm#31931 and helm#31932 which addressed pkg/kube. Fixes helm#31846 Signed-off-by: abhay1999 <[email protected]> Signed-off-by: abhay1999 <[email protected]>
gjenkins8
approved these changes
Mar 12, 2026
TerryHowe
pushed a commit
that referenced
this pull request
Jul 18, 2026
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`) are obsolete since Go 1.11 where go.mod is the authoritative module path. These stale comments cause issues with downstream tooling such as Kythe. Removes the legacy import comments from 64 files across 20 packages: - cmd/helm - internal/chart/v3/lint and sub-packages - internal/plugin and sub-packages - internal/release/v2/util - pkg/chart/v2/lint and sub-packages - pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance - pkg/registry - pkg/release/v1/util - pkg/repo/v1 - pkg/storage and pkg/storage/driver Follows up on #31931 and #31932 which addressed pkg/kube. Fixes #31846 Signed-off-by: abhay1999 <[email protected]> Signed-off-by: abhay1999 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove pre-Go modules import path comments from
pkg/kubetest files:pkg/kube/ready_test.gopkg/kube/resource_test.gopkg/kube/statuswait_test.goWhy
Follow-up to #31931 which addressed the non-test files. As noted in this Copilot review comment, the
*_test.gofiles inpkg/kubestill had legacy import path comments. Since Go 1.11 (modules), these comments are redundant — thego.modfile is authoritative. Removing them from test files ensures consistency across the entire package.Addresses: #31931 (comment)