pkg/kube: remove legacy import comments#31931
Merged
gjenkins8 merged 1 commit intoMar 12, 2026
Merged
Conversation
pull-request-size
Bot
added
the
size/S
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes legacy Go import path comments from pkg/kube package files to eliminate inconsistent package import comments that can break downstream tooling (e.g., Kythe) in module-aware builds.
Changes:
- Removed
// import "helm.sh/helm/v4/pkg/kube"package import comments from multiplepkg/kube/*.gosource files. - Standardized
package kubedeclarations across the affected files to rely ongo.modas the canonical module path.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/kube/client.go | Removes legacy import path comment from the package declaration. |
| pkg/kube/converter.go | Removes legacy import path comment from the package declaration. |
| pkg/kube/factory.go | Removes legacy import path comment from the package declaration. |
| pkg/kube/ready.go | Removes legacy import path comment from the package declaration. |
| pkg/kube/resource.go | Removes legacy import path comment from the package declaration. |
| pkg/kube/resource_policy.go | Removes legacy import path comment from the package declaration. |
| pkg/kube/statuswait.go | Removes legacy import path comment from the package declaration. |
| pkg/kube/wait.go | Removes legacy import path comment from the package declaration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| */ | ||
|
|
||
| package kube // import "helm.sh/helm/v4/pkg/kube" | ||
| package kube |
There was a problem hiding this comment.
There are still legacy import path comments in this package’s *_test.go files (e.g., ready_test.go/resource_test.go/statuswait_test.go). If the goal is to eliminate package-level import comments from pkg/kube for consistency/tooling (Kythe), those should be removed as well so the package is consistently module-path-only across all files.
Contributor
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
Contributor
There was a problem hiding this comment.
Import path comments (e.g. `// import "helm.sh/helm/v4/pkg/kube"`) are a pre-Go modules convention no longer needed in module-aware builds. Some files in pkg/kube had these comments while others did not, causing inconsistency that triggered downstream Kythe indexing errors. Remove the import comments from all affected files to make the package declaration consistent across the directory. Fixes helm#31846 Co-Authored-By: Claude Sonnet 4.6 <[email protected]> Signed-off-by: abhay1999 <[email protected]>
abhay1999
force-pushed
the
fix/remove-legacy-import-comments-pkg-kube
branch
from
March 12, 2026 05:40
7831073 to
d7cdc9e
Compare
abhay1999
added a commit
to abhay1999/helm
that referenced
this pull request
Mar 12, 2026
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`) are obsolete since Go 1.11 where go.mod is the authoritative module path. These stale comments cause issues with downstream tooling such as Kythe. Removes the legacy import comments from 64 files across 20 packages: - cmd/helm - internal/chart/v3/lint and sub-packages - internal/plugin and sub-packages - internal/release/v2/util - pkg/chart/v2/lint and sub-packages - pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance - pkg/registry - pkg/release/v1/util - pkg/repo/v1 - pkg/storage and pkg/storage/driver Follows up on helm#31931 and helm#31932 which addressed pkg/kube. Fixes helm#31846 Signed-off-by: abhay1999 <[email protected]> Signed-off-by: abhay1999 <[email protected]>
gjenkins8
approved these changes
Mar 12, 2026
TerryHowe
pushed a commit
that referenced
this pull request
Jul 18, 2026
Pre-Go-modules import path comments (e.g. `// import "helm.sh/helm/v4/..."`) are obsolete since Go 1.11 where go.mod is the authoritative module path. These stale comments cause issues with downstream tooling such as Kythe. Removes the legacy import comments from 64 files across 20 packages: - cmd/helm - internal/chart/v3/lint and sub-packages - internal/plugin and sub-packages - internal/release/v2/util - pkg/chart/v2/lint and sub-packages - pkg/cmd, pkg/engine, pkg/ignore, pkg/provenance - pkg/registry - pkg/release/v1/util - pkg/repo/v1 - pkg/storage and pkg/storage/driver Follows up on #31931 and #31932 which addressed pkg/kube. Fixes #31846 Signed-off-by: abhay1999 <[email protected]> Signed-off-by: abhay1999 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Import path comments (e.g.
// import "helm.sh/helm/v4/pkg/kube") are a pre-Go modules convention that is no longer needed in module-aware builds. Some files inpkg/kube/had these comments while others did not, causing inconsistency that triggered downstream Kythe indexing errors.Affected files:
pkg/kube/client.gopkg/kube/statuswait.gopkg/kube/ready.gopkg/kube/wait.gopkg/kube/resource.gopkg/kube/converter.gopkg/kube/factory.gopkg/kube/resource_policy.goWhy
Since Go 1.11 (modules), import path comments are redundant — the
go.modfile is the authoritative source for the module path. Having them in some files but not others within the same package causes inconsistency and breaks downstream static analysis tools like Kythe.Fixes #31846