Restore lint rule for excluding meaningless name#31330
Merged
Conversation
This rule is needed for packages like 'util'. Changes to those packages trigger this rule. Signed-off-by: Matt Farina <[email protected]>
pull-request-size
bot
added
the
size/XS
This was referenced Sep 25, 2025
Collaborator
Author
|
@benoittgt nothing to be sorry about. Should have had a comment explaining this case so it's not in just some maintainer minds. |
Member
|
strange, I ran |
gjenkins8
approved these changes
Sep 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule is needed for packages like 'util'. Changes to those packages trigger this rule.
What this PR does / why we need it: Changes to the util packages trigger this rule. Until this is restored, no PR that changes those packages will pass linting.
Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)