Skip to content

Warn when we fallback to a different version on helm pull#31254

Merged
gjenkins8 merged 1 commit into
helm:mainfrom
benoittgt:fix-31253-closest-version
Sep 23, 2025
Merged

Warn when we fallback to a different version on helm pull#31254
gjenkins8 merged 1 commit into
helm:mainfrom
benoittgt:fix-31253-closest-version

Conversation

@benoittgt

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Closes: #31253

Special notes for your reviewer:

  1. Do we want to have this only on v3 and on v4 we raise ErrNoChartVersion when we do no have exact match?
  2. Do we want to backport this?

If applicable:

  • this PR contains user facing changes (the docs needed label should be applied if so)
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

@pull-request-size pull-request-size Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2025
@benoittgt
benoittgt marked this pull request as ready for review September 5, 2025 17:31

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gjenkins8
gjenkins8 merged commit 23c5662 into helm:main Sep 23, 2025
5 checks passed
@scottrigby scottrigby added this to the 4.0.0 milestone Oct 16, 2025
@benoittgt
benoittgt deleted the fix-31253-closest-version branch November 20, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

helm pull silently pulling a different chart version if the one specified doesn't exist

5 participants