[HIP-0026] Move pkg/plugin -> internal/plugin #31142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/M
Signed-off-by: George Jenkins <[email protected]>
gjenkins8
force-pushed
the
gjenkins/main/mv_plugin_internal
branch
from
8e2541d to
a1c84f9
Compare
This was referenced Aug 17, 2025
Closed
gjenkins8
changed the title
scottrigby
added
feature
v4.x
jessesimpson36
approved these changes
Aug 18, 2025
Contributor
jessesimpson36
left a comment
jessesimpson36
left a comment
There was a problem hiding this comment.
I was already reviewing this code, but as a smaller part of the _plugin-system_squash_rebase_main branch (I think from @scottrigby 's fork. )
So this looks good to me.
scottrigby
approved these changes
Aug 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of implementing hip-0026. For full context, see:
What this PR does / why we need it:
This PR moves the existing plugin package to
internal/, as a precursor for merging in changes from https://github.com/scottrigby/helm/tree/plugin-system (the reworked plugin system to support greater plugin extensibility and Wasm based plugins)(As part of those changes, public interfaces will be returned to
pkg/plugin)Special notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)