chore: remove github.com/hashicorp/go-multierror dependency
#30781
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
mmorel-35
force-pushed
the
github.com/hashicorp/go-multierror
branch
from
8d5c735 to
55f2d3b
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
github.com/hashicorp/go-multierror
branch
from
55f2d3b to
d3eeb2c
Compare
mattfarina
added
the
Has One Approval
godhanipayal
approved these changes
Apr 21, 2025
scottrigby
approved these changes
Apr 22, 2025
Member
scottrigby
left a comment
scottrigby
left a comment
There was a problem hiding this comment.
@mmorel-35 Thanks for this PR. Nice work.
Also noting that while this is also addressed in #13460, that doesn't include the depguard rule to .golangci.yml like your PR does. Because of this I think we should merge this, and then the other PR can rebase against main again to focus only on "github.com/pkg/errors". I also think that PR should add a similar depguard rule for that package after this merges. Will note there.
scottrigby
added
refactor
and removed
Has One Approval
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
remove
github.com/hashicorp/go-multierrordependencygithub.com/hashicorp/go-multierroris under MPL-2.0 License which is not approved in CNCF AllowlistSpecial notes for your reviewer:
If applicable:
docs neededlabel should be applied if so)