replace hashicorp multierror with core errors #12298
Closed
+27
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Julian <[email protected]>
pull-request-size
bot
added
the
size/M
scottrigby
added
needs-rebase
2 tasks
Member
|
we should have merged your PR a long time ago, but since then the dep has been removed (#30781). We also have a depguard rule for this now too, which we should do for packages that are unmaintained or we want to explicitly avoid (see #13460 (review)). But yay, retroactive thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This just moves from using the hashicorp multierrors pkg to the core errors pkg. One thing this does is reduce the licensing burden.
Special notes for your reviewer:
If applicable: