Add skip-schema-validation flag #11510
Conversation
pull-request-size
bot
added
the
size/L
Adds a "--skip-schema-validation" flag option for helm install, upgrade, lint, and template that skips validation of the values.schema.json file. Signed-off-by: JvD_Ericsson <[email protected]>
Signed-off-by: Jeff van Dam <[email protected]>
|
This is valuable for scenarios where one creates a chart and uses other mechanisms to validate the values.yaml file but wants to ensure their chart still produces valid YAML. Since a lot of templates use Go template syntax, YAML validation is often enough. |
|
Could the maintainers look to progress this, please? |
|
any chance this will get in |
|
Why is this open so long? Looks like ready and complete. Ty @JvD-Ericsson |
|
cc: @hickeyma |
|
Desperately need this, I have offline environments to support and forking charts just to remove validation is a royal PITA. |
|
@JvD-Ericsson can you resolve the conflicts, maybe it will helm advance this PR ? |
Signed-off-by: Jeff van Dam <[email protected]>
|
Resolved now. Maybe @mattfarina or @joejulian can review now |
pkg/action/__debug_bin
Outdated
There was a problem hiding this comment.
I think you added this file by mistake
| @@ -45,7 +45,7 @@ var ( | |||
| ) | |||
|
|
|||
| // Templates lints the templates in the Linter. | |||
| func Templates(linter *support.Linter, values map[string]interface{}, namespace string, strict bool) { | |||
| func Templates(linter *support.Linter, values map[string]interface{}, namespace string, strict bool, skipSchemaValidation bool) { | |||
There was a problem hiding this comment.
this probably needs a new method like (ToRenderValuesSkipSchemaValidation) to keep api backward compatibilty ?
There was a problem hiding this comment.
Correct 👍 we can not change the signature of public functions in Helm 3
Signed-off-by: Jeff van Dam <[email protected]>
|
Tried a new approach in #12743 |
|
Any updated on this. I verified latest helm binary however couldn't find the flag --skip-schema-validation |
What this PR does / why we need it:
Adds a "--skip-schema-validation" flag option for helm install, upgrade, lint, and template that skips validation of the values.schema.json file.
closes #10398
Special notes for your reviewer:
This is my first time contributing, so please let me know if there is something I am doing wrong : )
If applicable:
Signed-off-by: Jeff van Dam [email protected]