overwrite flag added to az storage blob upload-batch#10726
Merged
Conversation
Signed-off-by: Sourik Ghosh <[email protected]>
pull-request-size
Bot
added
the
size/XS
Member
|
/lgtm |
Contributor
Author
|
@jdolitsky can you have a look at this |
jdolitsky
suggested changes
Mar 8, 2022
jdolitsky
left a comment
jdolitsky
left a comment
Contributor
There was a problem hiding this comment.
I was thinking about this. The new behavior actually protects from supply chain attacks.
Could you modify this to only add --overwrite if [[ "${VERSION}" == "canary" ]] ?
Signed-off-by: Sourik Ghosh <[email protected]>
jdolitsky
reviewed
Mar 8, 2022
Comment on lines
+49
to
+53
| if [[ "${VERSION}" == "canary" ]]; then | ||
| az storage blob upload-batch -s _dist/ -d "$AZURE_STORAGE_CONTAINER_NAME" --pattern 'helm-*' --connection-string "$AZURE_STORAGE_CONNECTION_STRING" --overwrite | ||
| else | ||
| az storage blob upload-batch -s _dist/ -d "$AZURE_STORAGE_CONTAINER_NAME" --pattern 'helm-*' --connection-string "$AZURE_STORAGE_CONNECTION_STRING" | ||
| if No newline at end of file |
Contributor
There was a problem hiding this comment.
last thing, can we format this?
if [[ "${VERSION}" == "canary" ]]; then
az storage blob upload-batch -s _dist/ -d "$AZURE_STORAGE_CONTAINER_NAME" --pattern 'helm-*' --connection-string "$AZURE_STORAGE_CONNECTION_STRING" --overwrite
else
az storage blob upload-batch -s _dist/ -d "$AZURE_STORAGE_CONTAINER_NAME" --pattern 'helm-*' --connection-string "$AZURE_STORAGE_CONNECTION_STRING"
if
Contributor
Author
There was a problem hiding this comment.
ohhh snap,,, yeah yeah
Signed-off-by: Sourik Ghosh <[email protected]>
jdolitsky
approved these changes
Mar 8, 2022
Contributor
|
thanks @sourikghosh ! |
mattfarina
added
needs-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sourik Ghosh [email protected]
What this PR does / why we need it:
adds a overwrite flag to az storage blob upload-batch to replace canary.
closes #10724
Special notes for your reviewer:
If applicable: