Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to Helm 3.16 broke dependencies references #13324

Closed
mhotan opened this issue Sep 11, 2024 · 4 comments · Fixed by #13327
Closed

Upgrading to Helm 3.16 broke dependencies references #13324

mhotan opened this issue Sep 11, 2024 · 4 comments · Fixed by #13327
Labels
bug Categorizes issue or PR as related to a bug.

Comments

@mhotan
Copy link

mhotan commented Sep 11, 2024

running helm update with pre 3.16 depenencies list starting to fail due to malformed download URLs.

Example command

helm dep update /path/to/local/chart/

Example Chart.yaml snippet

dependencies:
  - name: docker-registry
    version: 2.2.2
    repository: https://helm.twun.io/
    condition: ...

Saving 5 charts
Downloading docker-registry from repo https://helm.twun.io/
Save error occurred:  could not download docker-registry-2.2.2.tgz: non-absolute URLs should be in form of repo_name/path_to_chart, got: docker-registry-2.2.2.tgz
Error: could not download docker-registry-2.2.2.tgz: non-absolute URLs should be in form of repo_name/path_to_chart, got: docker-registry-2.2.2.tgz
make: *** [helm] Error 1

Output of helm version:

helm version
version.BuildInfo{Version:"v3.16.0", GitCommit:"0d439e1a09683f21a0ab9401eb661401f185b00b", GitTreeState:"clean", GoVersion:"go1.22.6"}

Output of kubectl version:

❯ kubectl version
Client Version: v1.29.4
Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3
Server Version: v1.30.3-eks-a18cd3a

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
Helm template locally
@insider89
Copy link

Have same issue

@iganev0886
Copy link

Same here, broke our entire pipeline

@mhotan
Copy link
Author

mhotan commented Sep 12, 2024

We've pinned the version in our build scripts as a short-term mitigation.

curl https://raw.githubusercontent.com/helm/helm/main/scripts/get-helm-3 | DESIRED_VERSION=v3.15.4 bash

@mattfarina mattfarina added bug Categorizes issue or PR as related to a bug. labels Sep 12, 2024
mattfarina added a commit to mattfarina/helm that referenced this issue Sep 12, 2024
@mattfarina
Revert "Improve helm dependency update performance"
c81bd89 
The change in helm#11726 caused a regression where `helm dependency udpate`
stopped working. The format of the internal representation of the data
changed causing errors of "non-absolute URLs should be in form of
repo_name/path_to_chart". See helm#13324 for more details.

Since this change is in released Helm and it's a regression, reverting
the original change was the fastest and safest route to deliver a
fix as quickly as possible.

Closes helm#13324

Signed-off-by: Matt Farina <[email protected]>
@mattfarina mattfarina mentioned this issue Sep 12, 2024
Merged
3 tasks
@mattfarina
Copy link
Collaborator

The PR has been created to fix the regression and it's under review. Planning an emergency release to fix the problem once the change is in.

@mattfarina mattfarina mentioned this issue Sep 12, 2024
Closed
@MichaelMorrisEst MichaelMorrisEst mentioned this issue Sep 19, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revert "Improve helm dependency update performance" mattfarina/helm
4 participants
@mattfarina @mhotan @insider89 @iganev0886