Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: helm/helm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.8.1
Choose a base ref
...
head repository: helm/helm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.8.2
Choose a head ref
  • 15 commits
  • 24 files changed
  • 7 contributors

Commits on Apr 8, 2022

  1. Reuse http transport

    Signed-off-by: Matthias Fehr <[email protected]>
    (cherry picked from commit aa33f4f)
    matthiasfehr authored and mattfarina committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    6c5adf1 View commit details
    Browse the repository at this point in the history
  2. Add transport option and tests

    Signed-off-by: Matthias Fehr <[email protected]>
    (cherry picked from commit 45367ca)
    matthiasfehr authored and mattfarina committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    ab4dc78 View commit details
    Browse the repository at this point in the history
  3. Add docs block

    Signed-off-by: Matthias Fehr <[email protected]>
    (cherry picked from commit 2acda0c)
    matthiasfehr authored and mattfarina committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    65b6e6d View commit details
    Browse the repository at this point in the history
  4. Pass http getter as pointer in tests

    Signed-off-by: Matthias Fehr <[email protected]>
    (cherry picked from commit 7d22040)
    matthiasfehr authored and mattfarina committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    b216f76 View commit details
    Browse the repository at this point in the history
  5. Dont modify provided transport

    Signed-off-by: Matthias Fehr <[email protected]>
    (cherry picked from commit cab1fc8)
    matthiasfehr authored and mattfarina committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    f4276f4 View commit details
    Browse the repository at this point in the history
  6. Updating vcs to latest version

    vcs had a release due to a CVE. This updates to the latest version
    that mitigates the CVE.
    
    Note, the Makefile was updated so that `make build` would build
    without cgo just like gox does in the CI pipeline. They should
    both build without cgo so we can catch issues before merging to
    master where a canary build would pick up the problem.
    
    Signed-off-by: Matt Farina <[email protected]>
    (cherry picked from commit 3490f1e)
    mattfarina committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    c0a645a View commit details
    Browse the repository at this point in the history
  7. Bumping Kubernetes package versions

    Signed-off-by: Matt Farina <[email protected]>
    (cherry picked from commit a87ab07)
    mattfarina committed Apr 8, 2022
    Configuration menu
    Copy the full SHA
    9d3ce9b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2022

  1. Fix value precedence

    Fix value precedence when importing values from child. Closes #9940
    
    Signed-off-by: Aram Zegerius <[email protected]>
    (cherry picked from commit c4952c9)
    zegerius authored and mattfarina committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    5d017e1 View commit details
    Browse the repository at this point in the history
  2. Add tests for multi-level dependencies.

    Closes #9940
    
    Signed-off-by: Aram Zegerius <[email protected]>
    Signed-off-by: Ankita Bhopatkar <[email protected]>
    (cherry picked from commit 4b49f35)
    zegerius authored and mattfarina committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    d263aaa View commit details
    Browse the repository at this point in the history
  3. fix tarFromLocalDir saving file dependencies in dest path

    Signed-off-by: Matthew Fisher <[email protected]>
    (cherry picked from commit adfb52e)
    Matthew Fisher authored and mattfarina committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    bd77989 View commit details
    Browse the repository at this point in the history
  4. Make validation errors easier to fix

    Problem: the warnings don't give enough details about which
    values are problematic, only the name of the leaf key. This is
    all the more annoying when you have a chart depending on other charts.
    
    ```
    mainchart
     |
     +- subchart1
     +- subchart2
     +- subchart3
    ```
    
    Here are some warnings I get before the change:
    ```
    coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value
    coalesce.go:160: warning: skipped value for resources: Not a table.
    coalesce.go:160: warning: skipped value for googleSheetsServiceAccount: Not a table.
    coalesce.go:199: warning: destination for googleSheetsServiceAccount is a table. Ignoring non-table value
    coalesce.go:199: warning: destination for resources is a table. Ignoring non-table value []
    coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value
    coalesce.go:199: warning: destination for credentials is a table. Ignoring non-table value
    coalesce.go:160: warning: skipped value for resources: Not a table.
    coalesce.go:160: warning: skipped value for googleSheetsServiceAccount: Not a table.
    ```
    
    with fix:
    ```
    coalesce.go:162: warning: skipped value for subchart1.resources: Not a table.
    coalesce.go:162: warning: skipped value for subchart2.googleSheetsServiceAccount: Not a table.
    coalesce.go:211: warning: destination for subchart3.aws.credentials is a table. Ignoring non-table value ()
    coalesce.go:211: warning: destination for mainchart.subchart3.aws.credentials is a table. Ignoring non-table value ()
    coalesce.go:211: warning: destination for mainchart.subchart2.googleSheetsServiceAccount is a table. Ignoring non-table value ()
    coalesce.go:211: warning: destination for mainchart.subchart1.resources is a table. Ignoring non-table value ([])
    coalesce.go:162: warning: skipped value for subchart1.resources: Not a table.
    coalesce.go:162: warning: skipped value for subchart2.googleSheetsServiceAccount: Not a table.
    coalesce.go:211: warning: destination for subchart3.aws.credentials is a table. Ignoring non-table value ()
    ```
    
    Signed-off-by: Damien Nozay <[email protected]>
    
    add tests
    
    Signed-off-by: Damien Nozay <[email protected]>
    (cherry picked from commit 65ec3d6)
    dnozay authored and mattfarina committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    7df8251 View commit details
    Browse the repository at this point in the history
  5. Simplify testdata charts

    Signed-off-by: Aram Zegerius <[email protected]>
    Signed-off-by: Ankita Bhopatkar <[email protected]>
    (cherry picked from commit 3fd4a11)
    zegerius authored and mattfarina committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    7526b0e View commit details
    Browse the repository at this point in the history
  6. Simplify testdata charts

    Signed-off-by: Aram Zegerius <[email protected]>
    Signed-off-by: Ankita Bhopatkar <[email protected]>
    (cherry picked from commit 752aa6d)
    zegerius authored and mattfarina committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    cf45b1a View commit details
    Browse the repository at this point in the history
  7. Fixing downloader plugin error handling

    Signed-off-by: Zoran Krleza <[email protected]>
    (cherry picked from commit 06c39c8)
    pixslx authored and mattfarina committed Apr 12, 2022
    Configuration menu
    Copy the full SHA
    7c3f651 View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2022

  1. Bump oras.land/oras-go from 1.1.0 to 1.1.1

    Bumps [oras.land/oras-go](https://github.com/oras-project/oras-go) from 1.1.0 to 1.1.1.
    - [Release notes](https://github.com/oras-project/oras-go/releases)
    - [Commits](oras-project/oras-go@v1.1.0...v1.1.1)
    
    ---
    updated-dependencies:
    - dependency-name: oras.land/oras-go
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    (cherry picked from commit 6eee0de)
    dependabot[bot] authored and mattfarina committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    6e3701e View commit details
    Browse the repository at this point in the history
Loading