Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: helm/helm
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.11.2
Choose a base ref
...
head repository: helm/helm
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.11.3
Choose a head ref
  • 7 commits
  • 7 files changed
  • 6 contributors

Commits on Apr 6, 2023

  1. Fixes Readiness Check for statefulsets using partitioned rolling upda…

    …te. (#11774)
    
    * Fixes Readiness Check for statefulsets using partitioned rolling update.
    Fixes #11773
    
    This change updates readiness check in ready.go to correctly
    account for statefulsets that are utilizing a partitioned upgrade.
    These statefulsets only upgrade a subset of the managed pods with each call
    to helm upgrade. This causes the upgrade to legitimately hit the condition where
    sts.status.CurrentRevision != sts.Status.UpdateRevision which causes helm to mark
    the upgrade has failed when in fact it is successful.
    
    This change fixes that behavior to only check when partition is unspecified or 0.
    
    Signed-off-by: Aman Nijhawan <[email protected]>
    
    * Adding a unit test to verify that partitioned rolling upgrade for a statefulset works.
    
    Signed-off-by: Aman Nijhawan <[email protected]>
    
    ---------
    
    Signed-off-by: Aman Nijhawan <[email protected]>
    Co-authored-by: Aman Nijhawan <[email protected]>
    (cherry picked from commit eea2f27)
    2 people authored and mattfarina committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    7994bb4 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. chore(deps): bump github.com/containerd/containerd from 1.6.15 to 1.7.0

    Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.6.15 to 1.7.0.
    - [Release notes](https://github.com/containerd/containerd/releases)
    - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md)
    - [Commits](containerd/containerd@v1.6.15...v1.7.0)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/containerd/containerd
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    (cherry picked from commit 3994329)
    dependabot[bot] authored and mattfarina committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b6a8417 View commit details
    Browse the repository at this point in the history
  2. chore(deps): bump github.com/docker/docker

    Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.21+incompatible to 20.10.24+incompatible.
    - [Release notes](https://github.com/docker/docker/releases)
    - [Commits](moby/moby@v20.10.21...v20.10.24)
    
    ---
    updated-dependencies:
    - dependency-name: github.com/docker/docker
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    (cherry picked from commit aba9bd6)
    dependabot[bot] authored and mattfarina committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    88b2db4 View commit details
    Browse the repository at this point in the history
  3. Fix 32bit-x86 typo in testsuite

    The GOARCH here is 386 not i386. This caused a slightly odd test
    suite failure on that architecture:
    
    --- FAIL: TestPlatformPrepareCommand (0.00s)
         plugin_test.go:45: Expected arg="os-arch", got "linux-s390x"
         plugin_test.go:64: Expected arg="os-arch", got "linux-s390x"
    
    Signed-off-by: Dirk Müller <[email protected]>
    (cherry picked from commit 1fc8369)
    dirkmueller authored and mattfarina committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    272f6b9 View commit details
    Browse the repository at this point in the history
  4. Fix goroutine leak in action install

    During the install process there was a place where an install
    process could be stuck trying to write to a channel. This would
    happen when a context had completed prior to performInstall
    finishing. In a short running Helm Client this was not a problem.
    But, for long running applications that use Helm as an SDK there
    are problems where a memory leak ends up happening due to
    goroutines never being able to complete.
    
    This fix provides a means for performInstall to write to its
    channel using the method already used to fix the upgrade
    issue of the same kind.
    
    Fixes #11805
    
    Signed-off-by: Matt Farina <[email protected]>
    (cherry picked from commit 7c9d636)
    mattfarina committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    4a3a268 View commit details
    Browse the repository at this point in the history
  5. Fix goroutine leak in perform

    Signed-off-by: willzgli <[email protected]>
    (cherry picked from commit 11150cd)
    willzgli authored and mattfarina committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    548366c View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. chore(deps): bump golang.org/x/text from 0.7.0 to 0.9.0

    Bumps [golang.org/x/text](https://github.com/golang/text) from 0.7.0 to 0.9.0.
    - [Release notes](https://github.com/golang/text/releases)
    - [Commits](golang/text@v0.7.0...v0.9.0)
    
    ---
    updated-dependencies:
    - dependency-name: golang.org/x/text
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    (cherry picked from commit be14682)
    dependabot[bot] authored and mattfarina committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    66a969e View commit details
    Browse the repository at this point in the history
Loading