Remove unnecessary function arguments

banjoh · banjoh · commit d25b0d9056fe · 2024-10-22T17:56:58.000+01:00
Signed-off-by: Evans Mungai &lt;mbuevans@gmail.com&gt;
diff --git a/cmd/helm/dependency.go b/cmd/helm/dependency.go
@@ -94,7 +94,7 @@ func newDependencyCmd(cfg *action.Configuration, out io.Writer) *cobra.Command {
 
 	cmd.AddCommand(newDependencyListCmd(out))
 	cmd.AddCommand(newDependencyUpdateCmd(cfg, out))
-	cmd.AddCommand(newDependencyBuildCmd(cfg, out))
+	cmd.AddCommand(newDependencyBuildCmd(out))
 
 	return cmd
 }
diff --git a/cmd/helm/dependency_build.go b/cmd/helm/dependency_build.go
@@ -41,7 +41,7 @@ If no lock file is found, 'helm dependency build' will mirror the behavior
 of 'helm dependency update'.
 `
 
-func newDependencyBuildCmd(_ *action.Configuration, out io.Writer) *cobra.Command {
+func newDependencyBuildCmd(out io.Writer) *cobra.Command {
 	client := action.NewDependency()
 
 	cmd := &cobra.Command{
diff --git a/cmd/helm/package.go b/cmd/helm/package.go
@@ -47,7 +47,7 @@ If '--keyring' is not specified, Helm usually defaults to the public keyring
 unless your environment is otherwise configured.
 `
 
-func newPackageCmd(_ *action.Configuration, out io.Writer) *cobra.Command {
+func newPackageCmd(out io.Writer) *cobra.Command {
 	client := action.NewPackage()
 	valueOpts := &values.Options{}
 
diff --git a/cmd/helm/root.go b/cmd/helm/root.go
@@ -169,7 +169,7 @@ func newRootCmd(actionConfig *action.Configuration, out io.Writer, args []string
 		newPullCmd(actionConfig, out),
 		newShowCmd(actionConfig, out),
 		newLintCmd(out),
-		newPackageCmd(actionConfig, out),
+		newPackageCmd(out),
 		newRepoCmd(out),
 		newSearchCmd(out),
 		newVerifyCmd(out),

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ func newDependencyCmd(cfg action.Configuration, out io.Writer) cobra.Command {`
`94`	`94`
`95`	`95`	`cmd.AddCommand(newDependencyListCmd(out))`
`96`	`96`	`cmd.AddCommand(newDependencyUpdateCmd(cfg, out))`
`97`		`- cmd.AddCommand(newDependencyBuildCmd(cfg, out))`
	`97`	`+ cmd.AddCommand(newDependencyBuildCmd(out))`
`98`	`98`
`99`	`99`	`return cmd`
`100`	`100`	`}`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ If no lock file is found, 'helm dependency build' will mirror the behavior`
`41`	`41`	`of 'helm dependency update'.`
`42`	`42`	`
`43`	`43`
`44`		`-func newDependencyBuildCmd(_ action.Configuration, out io.Writer) cobra.Command {`
	`44`	`+func newDependencyBuildCmd(out io.Writer) *cobra.Command {`
`45`	`45`	`client := action.NewDependency()`
`46`	`46`
`47`	`47`	`cmd := &cobra.Command{`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ If '--keyring' is not specified, Helm usually defaults to the public keyring`
`47`	`47`	`unless your environment is otherwise configured.`
`48`	`48`	`
`49`	`49`
`50`		`-func newPackageCmd(_ action.Configuration, out io.Writer) cobra.Command {`
	`50`	`+func newPackageCmd(out io.Writer) *cobra.Command {`
`51`	`51`	`client := action.NewPackage()`
`52`	`52`	`valueOpts := &values.Options{}`
`53`	`53`