fix(dependencyBuild): prevent race condition in concurrent helm dependency

idsulik · idsulik · commit adeb4ca3d974 · 2024-06-16T16:52:05.000+03:00
Signed-off-by: Suleiman Dibirov &lt;idsulik@gmail.com&gt;
diff --git a/pkg/downloader/manager.go b/pkg/downloader/manager.go
@@ -246,7 +246,7 @@ func (m *Manager) downloadAll(deps []*chart.Dependency) error {
 	}
 
 	destPath := filepath.Join(m.ChartPath, "charts")
-	tmpPath := filepath.Join(m.ChartPath, "tmpcharts")
+	tmpPath := filepath.Join(m.ChartPath, fmt.Sprintf("tmpcharts-%d", os.Getpid()))
 
 	// Check if 'charts' directory is not actually a directory. If it does not exist, create it.
 	if fi, err := os.Stat(destPath); err == nil {

Original file line number	Diff line number	Diff line change
`@@ -246,7 +246,7 @@ func (m Manager) downloadAll(deps []chart.Dependency) error {`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`destPath := filepath.Join(m.ChartPath, "charts")`
`249`		`- tmpPath := filepath.Join(m.ChartPath, "tmpcharts")`
	`249`	`+ tmpPath := filepath.Join(m.ChartPath, fmt.Sprintf("tmpcharts-%d", os.Getpid()))`
`250`	`250`
`251`	`251`	`// Check if 'charts' directory is not actually a directory. If it does not exist, create it.`
`252`	`252`	`if fi, err := os.Stat(destPath); err == nil {`