fix: update error handling in Configuration.Init method, add tests for the method

idsulik · idsulik · commit 800c33a5aa1e · 2024-06-19T07:46:38.000+03:00
Signed-off-by: Suleiman Dibirov &lt;idsulik@gmail.com&gt;
diff --git a/pkg/action/action.go b/pkg/action/action.go
@@ -330,7 +330,7 @@ func GetVersionSet(client discovery.ServerResourcesInterface) (chartutil.Version
 	}
 
 	versionMap := make(map[string]interface{})
-	versions := []string{}
+	var versions []string
 
 	// Extract the groups
 	for _, g := range groups {
@@ -411,12 +411,11 @@ func (cfg *Configuration) Init(getter genericclioptions.RESTClientGetter, namesp
 			namespace,
 		)
 		if err != nil {
-			panic(fmt.Sprintf("Unable to instantiate SQL driver: %v", err))
+			return errors.Wrap(err, "unable to instantiate SQL driver")
 		}
 		store = storage.Init(d)
 	default:
-		// Not sure what to do here.
-		panic("Unknown driver in HELM_DRIVER: " + helmDriver)
+		return errors.Errorf("unknown driver %q", helmDriver)
 	}
 
 	cfg.RESTClientGetter = getter
diff --git a/pkg/action/action_test.go b/pkg/action/action_test.go
@@ -17,9 +17,11 @@ package action
 
 import (
 	"flag"
+	"fmt"
 	"io"
 	"testing"
 
+	"github.com/stretchr/testify/assert"
 	fakeclientset "k8s.io/client-go/kubernetes/fake"
 
 	"helm.sh/helm/v3/pkg/chart"
@@ -273,6 +275,74 @@ func namedReleaseStub(name string, status release.Status) *release.Release {
 	}
 }
 
+func TestConfiguration_Init(t *testing.T) {
+	tests := []struct {
+		name               string
+		helmDriver         string
+		expectedDriverType interface{}
+		expectErr          bool
+		errMsg             string
+	}{
+		{
+			name:               "Test secret driver",
+			helmDriver:         "secret",
+			expectedDriverType: &driver.Secrets{},
+		},
+		{
+			name:               "Test secrets driver",
+			helmDriver:         "secrets",
+			expectedDriverType: &driver.Secrets{},
+		},
+		{
+			name:               "Test empty driver",
+			helmDriver:         "",
+			expectedDriverType: &driver.Secrets{},
+		},
+		{
+			name:               "Test configmap driver",
+			helmDriver:         "configmap",
+			expectedDriverType: &driver.ConfigMaps{},
+		},
+		{
+			name:               "Test configmaps driver",
+			helmDriver:         "configmaps",
+			expectedDriverType: &driver.ConfigMaps{},
+		},
+		{
+			name:               "Test memory driver",
+			helmDriver:         "memory",
+			expectedDriverType: &driver.Memory{},
+		},
+		{
+			name:       "Test sql driver",
+			helmDriver: "sql",
+			expectErr:  true,
+			errMsg:     "unable to instantiate SQL driver",
+		},
+		{
+			name:       "Test unknown driver",
+			helmDriver: "someDriver",
+			expectErr:  true,
+			errMsg:     fmt.Sprintf("unknown driver %q", "someDriver"),
+		},
+	}
+
+	for _, tt := range tests {
+		t.Run(tt.name, func(t *testing.T) {
+			cfg := &Configuration{}
+
+			actualErr := cfg.Init(nil, "default", tt.helmDriver, nil)
+			if tt.expectErr {
+				assert.Error(t, actualErr)
+				assert.Contains(t, actualErr.Error(), tt.errMsg)
+			} else {
+				assert.NoError(t, actualErr)
+				assert.IsType(t, tt.expectedDriverType, cfg.Releases.Driver)
+			}
+		})
+	}
+}
+
 func TestGetVersionSet(t *testing.T) {
 	client := fakeclientset.NewSimpleClientset()
 

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ func GetVersionSet(client discovery.ServerResourcesInterface) (chartutil.Version`
`330`	`330`	`}`
`331`	`331`
`332`	`332`	`versionMap := make(map[string]interface{})`
`333`		`- versions := []string{}`
	`333`	`+ var versions []string`
`334`	`334`
`335`	`335`	`// Extract the groups`
`336`	`336`	`for _, g := range groups {`
`@@ -411,12 +411,11 @@ func (cfg *Configuration) Init(getter genericclioptions.RESTClientGetter, namesp`
`411`	`411`	`namespace,`
`412`	`412`	`)`
`413`	`413`	`if err != nil {`
`414`		`- panic(fmt.Sprintf("Unable to instantiate SQL driver: %v", err))`
	`414`	`+ return errors.Wrap(err, "unable to instantiate SQL driver")`
`415`	`415`	`}`
`416`	`416`	`store = storage.Init(d)`
`417`	`417`	`default:`
`418`		`- // Not sure what to do here.`
`419`		`- panic("Unknown driver in HELM_DRIVER: " + helmDriver)`
	`418`	`+ return errors.Errorf("unknown driver %q", helmDriver)`
`420`	`419`	`}`
`421`	`420`
`422`	`421`	`cfg.RESTClientGetter = getter`