fix(hooks): correct hooks delete order

idsulik · mattfarina · commit 19fe320ae87e · 2024-11-11T12:11:32.000-07:00
Signed-off-by: Suleiman Dibirov <idsulik@gmail.com> (cherry picked from commit f4f4a6b)
diff --git a/pkg/action/hooks.go b/pkg/action/hooks.go
@@ -99,7 +99,8 @@ func (cfg *Configuration) execHook(rl *release.Release, hook release.HookEvent,
 
 	// If all hooks are successful, check the annotation of each hook to determine whether the hook should be deleted
 	// under succeeded condition. If so, then clear the corresponding resource object in each hook
-	for _, h := range executingHooks {
+	for i := len(executingHooks) - 1; i >= 0; i-- {
+		h := executingHooks[i]
 		if err := cfg.deleteHookByPolicy(h, release.HookSucceeded, timeout); err != nil {
 			return err
 		}

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,8 @@ func (cfg Configuration) execHook(rl release.Release, hook release.HookEvent,`
`99`	`99`
`100`	`100`	`// If all hooks are successful, check the annotation of each hook to determine whether the hook should be deleted`
`101`	`101`	`// under succeeded condition. If so, then clear the corresponding resource object in each hook`
`102`		`- for _, h := range executingHooks {`
	`102`	`+ for i := len(executingHooks) - 1; i >= 0; i-- {`
	`103`	`+ h := executingHooks[i]`
`103`	`104`	`if err := cfg.deleteHookByPolicy(h, release.HookSucceeded, timeout); err != nil {`
`104`	`105`	`return err`
`105`	`106`	`}`