[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pickledrick
We suggest the following additional approver: mgoodness

Assign the PR to them by writing /assign @mgoodness in a comment when ready.

The full list of commands accepted by this bot can be found here.

/assign @mgoodness

@unguiculus is @mgoodness the right person for this?

Have you had a look at https://github.com/coreos/prometheus-operator/tree/master/helm?

These charts are under very active development. It probalby doesn't make much sense to have another chart here.

cc @gianrubio @brancz

@unguiculus I was not aware they were there. I thought there'd be a reason why they were not in this repo already. Happy to decline if you see no value here.

Thanks a lot for tagging us @unguiculus !

The ultimate goal of the helm charts in the prometheus operator repo is to have them here as well, however, the project itself as well as everything around it, is so fast moving, that it's very hard to maintain in separate repositories. When they are in the prometheus operator repo, there is little syncronization necessary.

I do want to take apart the helm charts in the Prometheus Operator repo however. Maybe this can be the start?

@gianrubio what do you think about this? My take would be that these three charts should be easily extracted and be in the official helm charts

• node-exporter
• prometheus-operator
• kube-state-metrics
• alertmanager (created through prometheus-operator)
• prometheus (created through prometheus-operator)

Then the parts that are hard to syncronize (mostly the kube-prometheus parts) can continue to live on in the prometheus-operator repo, but the common and reusable parts can be here. (I would also hold off on the grafana chart for now as there are a lot of changes coming for v5.0)

@gianrubio what do you think about this? My take would be that these three charts should be easily extracted and be in the official helm charts

Fully agreed, I already had pointed to move prometheus-operator chart to the oficial repo.

Seeing the current prometheus chart I'd like to split all this templates like node-exporter, kube-state, alertmanager in new charts and leave only kube-prometheus in the prometheus-operator repo. @unguiculus what are your thoughts?

@gianrubio I agree.

Sounds good to me!

/ok-to-test

@brancz @gianrubio as members of the Kubernetes orgs, you can add yourselves to OWNERS files to any charts you move here. This will give folks in the OWNERS files to test and approve PRs for merge, which hopefully gives you the flexibility to move faster within this repo also. If you aren't yet in the org, you can see how you can apply for membership here https://github.com/kubernetes/community/blob/master/community-membership.md. We can certainly help and sponsor new people after one or two contributions to the prometheus charts.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@gianrubio I understand you would like to maintain the chart in both the prometheus-operator as the "upstream" and sync changes here as a "downstream" but as part of the official helm charts. Is that correct? In that case I think we should update this PR to reflect the latest state of the chart in the upstream repo and move forward with this.

Any update on this?

This issue is being automatically closed due to inactivity.

cc @gianrubio

thanks for pinging me @brancz, it's ok to close this issue since there's another PR #6765 to address prom operator.