This repository was archived by the owner on Feb 22, 2022. It is now read-only.
[stable/phpbb] Update deployment apiVersion to 'apps/v1' - Mandatory for K8s 1.16#17307
Merged
Conversation
…for K8s 1.16 Signed-off-by: juan131 <[email protected]>
helm-bot
added
Contribution Allowed
k8s-ci-robot
added
the
approved
Collaborator
|
/ok-to-test |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juan131, miguelaeh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ramkumarvs
pushed a commit
to yugabyte/charts-helm-fork
that referenced
this pull request
Sep 30, 2019
…for K8s 1.16 (helm#17307) Signed-off-by: juan131 <[email protected]>
ali-sattari
pushed a commit
to ali-sattari/charts
that referenced
this pull request
Oct 7, 2019
…for K8s 1.16 (helm#17307) Signed-off-by: juan131 <[email protected]> Signed-off-by: Ali Sattari <[email protected]>
sameersbn
pushed a commit
to sameersbn/kubernetes-charts
that referenced
this pull request
Nov 8, 2019
In helm#17307 the `apiVersion` of the deployment resource was updated to `apps/v1` in tune with the api's deprecated in k8s 1.16. This change however breaks upgradability of existing phpbb deployments with helm v3 (rc) as described in helm/helm#6646. To fix this, we have defined a `phpbb.deployment.apiVersion` helper that returns the new `apiVersion` only when k8s 1.16 or higher is in use. Signed-off-by: Sameer Naik <[email protected]>
4 tasks
sameersbn
pushed a commit
to sameersbn/kubernetes-charts
that referenced
this pull request
Nov 9, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17307 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. This major version signifies this change. Signed-off-by: Sameer Naik <[email protected]>
sameersbn
pushed a commit
to sameersbn/kubernetes-charts
that referenced
this pull request
Nov 11, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17307 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. This major version signifies this change. Signed-off-by: Sameer Naik <[email protected]>
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 12, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In #17307 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. This major version signifies this change. Signed-off-by: Sameer Naik <[email protected]>
JoseAlban
pushed a commit
to JoseAlban/charts
that referenced
this pull request
Nov 22, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17307 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. This major version signifies this change. Signed-off-by: Sameer Naik <[email protected]>
hakman
pushed a commit
to hakman/charts
that referenced
this pull request
Dec 5, 2019
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17307 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. This major version signifies this change. Signed-off-by: Sameer Naik <[email protected]>
dargolith
pushed a commit
to dargolith/charts
that referenced
this pull request
Jan 10, 2020
Helm performs a lookup for the object based on its group (apps), version (v1), and kind (Deployment). Also known as its GroupVersionKind, or GVK. Changing the GVK is considered a compatibility breaker from Kubernetes' point of view, so you cannot "upgrade" those objects to the new GVK in-place. Earlier versions of Helm 3 did not perform the lookup correctly which has since been fixed to match the spec. In helm#17307 the `apiVersion` of the deployment resources was updated to `apps/v1` in tune with the api's deprecated, resulting in compatibility breakage. This major version signifies this change. Signed-off-by: Sameer Naik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: juan131 [email protected]
What this PR does / why we need it:
There are several deprecations in the API introduced in
K8s 1.16(see https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.16.md#deprecations-and-removals) which affect our manifests. The following APIs are no longer served by default:apps/v1beta1andapps/v1beta2- useapps/v1insteadextensions/v1beta1- useapps/v1insteadextensions/v1beta1- usenetworking.k8s.io/v1insteadextensions/v1beta1- usepolicy/v1beta1insteadThis PR address the changes to be done for
stable/phpbb.Checklist
[stable/chart])