Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

[incubator/linkerd2] New chart for Linkerd2#16472

Closed
alpeb wants to merge 4 commits intohelm:masterfrom
linkerd:alpeb/linkerd2-chart
Closed

[incubator/linkerd2] New chart for Linkerd2#16472
alpeb wants to merge 4 commits intohelm:masterfrom
linkerd:alpeb/linkerd2-chart

Conversation

@alpeb
Copy link

@alpeb alpeb commented Aug 20, 2019

What this PR does / why we need it:

This is a chart for Linkerd2, that didn't exist in this repo.

Special notes for your reviewer:

This is the official chart from the Linkerd2's maintainers. Looking forward for your comments :)

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/chart])

@alpeb
[incubator/linkerd2] New chart for Linkerd2
4d30161 
The official Helm chart for Linkerd2!
Looking forward for your comments :)

Signed-off-by: Alejandro Pedraza <[email protected]>
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 20, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alpeb
To complete the pull request process, please assign scottrigby
You can assign the PR to them by writing /assign @scottrigby in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@helm-bot helm-bot added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 20, 2019
@helm-bot helm-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 20, 2019
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 20, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 20, 2019

Hi @alpeb. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Aug 20, 2019
@alpeb
Copy link
Author

alpeb commented Aug 20, 2019

/assign @scottrigby

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Aug 20, 2019

The following users are mentioned in OWNERS file(s) but are not members of the helm org.

Once all users have been added as members of the org, you can trigger verification by writing /verify-owners in a comment.

  • grampelberg
    • incubator/linkerd2/OWNERS
  • alpeb
    • incubator/linkerd2/OWNERS
  • ihcsim
    • incubator/linkerd2/OWNERS

@alpeb
Copy link
Author

alpeb commented Aug 26, 2019

Hi @scottrigby, any feedback on this PR? Is there something else pending we need to do on our side before this can get reviewed? Thanks.

@ritazh
Copy link
Contributor

ritazh commented Aug 28, 2019

cc @michelleN

@Aisuko
Copy link
Contributor

Aisuko commented Sep 18, 2019

I'm sorry for replying to this too late.

Please take a look at helm/helm#6095 (comment)

We strongly encourage people to self-host chart repos:
https://github.com/helm/hub/blob/master/Repositories.md

You can even do that using GitHub pages:
https://github.com/helm/hub/blob/master/docs/github.md#github-pages-as-a-repository

@alpeb alpeb mentioned this pull request Oct 3, 2019
Closed
@alpeb
Copy link
Author

alpeb commented Oct 3, 2019

Thanks @Aisuko . We ended up publishing our own repos and submitting to the Helm Hub, so I'm closing this issue.

@alpeb alpeb closed this Oct 3, 2019
@alpeb alpeb deleted the alpeb/linkerd2-chart branch October 3, 2019 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cpanato cpanato Awaiting requested review from cpanato

@sameersbn sameersbn Awaiting requested review from sameersbn

Assignees

@scottrigby scottrigby

Labels

Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@alpeb @k8s-ci-robot @ritazh @Aisuko @scottrigby @helm-bot