Skip to content
This repository was archived by the owner on Feb 22, 2022. It is now read-only.

Comments

[stable/concourse] add new parameter for Concourse 5.5#15978

Merged
k8s-ci-robot merged 1 commit intohelm:masterfrom
concourse:add-new-param-for-5.5.0
Sep 6, 2019
Merged

[stable/concourse] add new parameter for Concourse 5.5#15978
k8s-ci-robot merged 1 commit intohelm:masterfrom
concourse:add-new-param-for-5.5.0

Conversation

@zoetian
Copy link
Contributor

@zoetian zoetian commented Jul 30, 2019

What this PR does / why we need it:

The latest developing concourse version is failing on k8s pipeline job k8s-check-helm-params for missing the variable CONCOURSE_MAX_ACTIVE_TASKS_PER_WORKER in concourse helm chart. We're adding this per the code changes for limit-active-task (per worker) when the containerPlacementStrategy is set to use it.

Which issue this PR fixes

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [stable/chart])

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 30, 2019
@helm-bot helm-bot added Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 30, 2019

Hi @zoetian. Thanks for your PR.

I'm waiting for a helm member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot requested review from YoussB and cirocosta July 30, 2019 17:44
@zoetian zoetian mentioned this pull request Aug 2, 2019
Closed
3 tasks
[stable/concourse] add parameters for 5.5
18d9f82 
This commit adds the new parameters that were added to Concourse 5.5.

Here's a breakdown of the new parameters:

- max-active-tasks-per-worker

  > used by the `limit-active-tasks` container placement strategy
  > concourse/concourse#4118

- support for influxdb batching and bigger buffer size for metrics emissions

  > concourse/concourse#3937

- limitting number of max connections in db conn pools

  > concourse/concourse#4232

Signed-off-by: Ciro S. Costa <[email protected]>
Co-authored-by: Zoe Tian <[email protected]>
@helm-bot helm-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 23, 2019
@cirocosta
Copy link
Collaborator

cirocosta commented Aug 23, 2019

Hey,

Here's a breakdown of the new parameters:

😁

@jomsie jomsie mentioned this pull request Sep 6, 2019
Merged
@zoetian zoetian marked this pull request as ready for review September 6, 2019 14:32
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 6, 2019
@cirocosta
Copy link
Collaborator

cirocosta commented Sep 6, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2019
@cirocosta
Copy link
Collaborator

cirocosta commented Sep 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 6, 2019
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cirocosta, zoetian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 96c33a2 into helm:master Sep 6, 2019
@cirocosta cirocosta deleted the add-new-param-for-5.5.0 branch September 6, 2019 14:45
kengou pushed a commit to kengou/charts that referenced this pull request Sep 18, 2019
@zoetian @kengou
[stable/concourse] add parameters for 5.5 (helm#15978)
8fc7b6f 
This commit adds the new parameters that were added to Concourse 5.5.

Here's a breakdown of the new parameters:

- max-active-tasks-per-worker

  > used by the `limit-active-tasks` container placement strategy
  > concourse/concourse#4118

- support for influxdb batching and bigger buffer size for metrics emissions

  > concourse/concourse#3937

- limitting number of max connections in db conn pools

  > concourse/concourse#4232

Signed-off-by: Ciro S. Costa <[email protected]>
Co-authored-by: Zoe Tian <[email protected]>
ramkumarvs pushed a commit to yugabyte/charts-helm-fork that referenced this pull request Sep 30, 2019
@zoetian
[stable/concourse] add parameters for 5.5 (helm#15978)
b8c8ebb 
This commit adds the new parameters that were added to Concourse 5.5.

Here's a breakdown of the new parameters:

- max-active-tasks-per-worker

  > used by the `limit-active-tasks` container placement strategy
  > concourse/concourse#4118

- support for influxdb batching and bigger buffer size for metrics emissions

  > concourse/concourse#3937

- limitting number of max connections in db conn pools

  > concourse/concourse#4232

Signed-off-by: Ciro S. Costa <[email protected]>
Co-authored-by: Zoe Tian <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cirocosta cirocosta Awaiting requested review from cirocosta

@YoussB YoussB Awaiting requested review from YoussB

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). lgtm Indicates that a PR is ready to be merged. ok-to-test size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[stable/concourse] Add missing CONCOURSE_MAX_ACTIVE_TASKS_PER_WORKER flag

4 participants

@zoetian @k8s-ci-robot @cirocosta @helm-bot