feat: customize welcome page#557
Merged
Merged
Conversation
cbuto
requested changes
Mar 6, 2022
cbuto
reviewed
Mar 6, 2022
cbuto
reviewed
Mar 8, 2022
cbuto
left a comment
cbuto
left a comment
Contributor
There was a problem hiding this comment.
thanks for fixing the auth! I think this should be good to go once some basic unit tests are updated/added to cover this new feature. Thanks!!
dirien
force-pushed
the
welcome_page
branch
2 times, most recently
from
March 8, 2022 23:37
e1fc6a0 to
93d4633
Compare
Contributor
Author
|
Hi @cbuto, add the tests and removed the folder with the example html files. The Readme has the new feature explained. Looking for your feedback :) |
cbuto
approved these changes
Mar 9, 2022
cbuto
left a comment
cbuto
left a comment
Contributor
There was a problem hiding this comment.
looks good! thanks for adding the tests!
maybe we can get one more review @nerdeveloper @scbizu?
cbuto
requested review from
a team,
nerdeveloper and
scbizu
and removed request for
nerdeveloper and
scbizu
March 9, 2022 15:07
scbizu
requested changes
Mar 11, 2022
scbizu
left a comment
scbizu
left a comment
Contributor
There was a problem hiding this comment.
Generally LGTM , adds some small code suggestions.
Contributor
Contributor
Author
|
HI @scbizu, thanks for the input. I changed the parts! Looking forward for your fedback! |
scbizu
reviewed
Mar 12, 2022
Contributor
Author
|
@scbizu done. moved the error check above the |
scbizu
requested changes
Mar 13, 2022
Signed-off-by: Engin Diri <[email protected]>
scbizu
approved these changes
Mar 15, 2022
Contributor
|
LGTM , merged . |
Contributor
Author
Contributor
|
Thanks for working on this @dirien! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #550
Hi,
this PR enables potential users to provide their own Welcome page.
With the flag
--web-template-path=<path>, you can specify the path to your custom welcome page.The structure of the folder should be like this:
web/ index.html xyz.html static/ main.css main.jsI use
c.HTMLto serve the custom welcome page, this means we have full access to the go-template engineThe rules are: Every file with html ending will be picked up. This is useful if you want to create templates and include them in the main index.html file (see my example). But only the
index.htmlwill be served!Static files (css, js or pics) should be saved into the
staticfolder. I check the code, if the static folder if present to serve this.If everybody like this, I will extend the enable the helm chart too.
Example:
Looking for your feedback!