fix: Use the github API to get the latest release version#553
Merged
Conversation
Signed-off-by: Casey Buto <[email protected]>
cbuto
force-pushed
the
fix/get-chartmuseum
branch
from
February 15, 2022 14:27
ed38664 to
a2d6f67
Compare
jdolitsky
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#552
The script was pulling
trueas the latest release version (i think the HTML changed). Instead of parsing the HTML, this changes the script to parse the JSON response from the API instead.I still need to look into gofish after this.