fix: avoid panic with dynamic depth configured#543
Merged
Conversation
Signed-off-by: Casey Buto <[email protected]>
Signed-off-by: Casey Buto <[email protected]>
cbuto
force-pushed
the
fix/dynamic-depth-panic
branch
from
February 3, 2022 15:51
0a1158c to
7e1f1fc
Compare
jdolitsky
approved these changes
Feb 3, 2022
jdolitsky
left a comment
jdolitsky
left a comment
Contributor
There was a problem hiding this comment.
this lgtm. thanks for finding!
nerdeveloper
pushed a commit
to nerdeveloper/chartmuseum
that referenced
this pull request
Feb 10, 2022
* fix: avoid panic with dynamic depth configured Signed-off-by: Casey Buto <[email protected]> * test: Add test for dynamic depth route Signed-off-by: Casey Buto <[email protected]> Signed-off-by: nerdeveloper <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #443.
In the case where depth = -1, I think we can assume the url didn't match any of the routes and thus doesn't exist. I went through a few cases and this seems like the desired behavior but I had a hard time understanding this entire flow. This did end up fixing the panics caused by routes that aren't matched with anything i.e
/favicon. I also tested a few scenarios using dynamic depth and everything looked to behave correctly.