Fix duplicate versions for same chart#492
Merged
Merged
Conversation
ninjadq
force-pushed
the
fix_duplicate_versions
branch
2 times, most recently
from
September 25, 2021 04:21
bd2d518 to
ccc3675
Compare
Contributor
|
Hi @ninjadq , could you add some test cases for this PR ? |
ninjadq
force-pushed
the
fix_duplicate_versions
branch
from
September 25, 2021 15:00
ccc3675 to
fba104a
Compare
Contributor
Author
|
hi @scbizu , added a case similar to chart only scenario |
scbizu
requested changes
Sep 25, 2021
Contributor
|
Added some review suggestions , thanks for your PR again |
ninjadq
force-pushed
the
fix_duplicate_versions
branch
from
September 26, 2021 03:22
fba104a to
c1a1020
Compare
* The detailed issue is described in helm#450 * And there is a PR helm#454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with helm#454 Signed-off-by: DQ <[email protected]>
ninjadq
force-pushed
the
fix_duplicate_versions
branch
from
September 26, 2021 03:32
c1a1020 to
5dd7f03
Compare
* If conflict, it didn't need to do the left logic, just return the file * move out file format check logic out of `validateChartOrProv` * these changes are discussed in helm#492 (comment) Signed-off-by: DQ <[email protected]>
scbizu
approved these changes
Sep 30, 2021
Contributor
|
LGTM 😎 |
Contributor
|
Merging , the bad CI will be fixed in #482 |
Contributor
Author
|
Thank you @scbizu, happy holidays |
Contributor
|
@ninjadq You too 🥰 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: DQ [email protected]