pkg/chartmuseum/server: upload chart should emit updateChart event with overwrite option is set#454
Merged
Merged
Conversation
Signed-off-by: scnace <[email protected]>
scbizu
force-pushed
the
fix/duplicate-index-entry
branch
from
May 3, 2021 07:10
9735d64 to
66cc263
Compare
scbizu
force-pushed
the
fix/duplicate-index-entry
branch
from
May 3, 2021 08:32
ee16a92 to
2f9f2f0
Compare
package when overwrite option is set ,index entry addChart should be updateChart under the overwrite cases. Signed-off-by: scnace <[email protected]>
scbizu
force-pushed
the
fix/duplicate-index-entry
branch
from
May 3, 2021 08:40
2f9f2f0 to
cd2e286
Compare
scbizu
changed the title
ninjadq
added a commit
to ninjadq/chartmuseum
that referenced
this pull request
Sep 24, 2021
* The detailed issue is described in helm#450 * And there is a PR helm#454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with helm#454 Signed-off-by: DQ <[email protected]>
ninjadq
added a commit
to ninjadq/chartmuseum
that referenced
this pull request
Sep 25, 2021
* The detailed issue is described in helm#450 * And there is a PR helm#454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with helm#454 Signed-off-by: DQ <[email protected]>
ninjadq
added a commit
to ninjadq/chartmuseum
that referenced
this pull request
Sep 25, 2021
* The detailed issue is described in helm#450 * And there is a PR helm#454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with helm#454 Signed-off-by: DQ <[email protected]>
ninjadq
added a commit
to ninjadq/chartmuseum
that referenced
this pull request
Sep 25, 2021
* The detailed issue is described in helm#450 * And there is a PR helm#454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with helm#454 Signed-off-by: DQ <[email protected]>
ninjadq
added a commit
to ninjadq/chartmuseum
that referenced
this pull request
Sep 26, 2021
* The detailed issue is described in helm#450 * And there is a PR helm#454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with helm#454 Signed-off-by: DQ <[email protected]>
ninjadq
added a commit
to ninjadq/chartmuseum
that referenced
this pull request
Sep 26, 2021
* The detailed issue is described in helm#450 * And there is a PR helm#454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with helm#454 Signed-off-by: DQ <[email protected]>
scbizu
pushed a commit
that referenced
this pull request
Sep 30, 2021
* Fix duplicate versions for same chart * The detailed issue is described in #450 * And there is a PR #454 fixed one scenario of this issue * But there is another ocassion in which users upload chart with prov * in this PR is to handle this situation with the way similar with #454 Signed-off-by: DQ <[email protected]> * Enhance: optimize loop in `getChartAndProvFiles` * If conflict, it didn't need to do the left logic, just return the file * move out file format check logic out of `validateChartOrProv` * these changes are discussed in #492 (comment) Signed-off-by: DQ <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to fix #450