Skip to content

pkg/chartmuseum/server: fix chart object path invalid#423

Merged
jdolitsky merged 2 commits into
helm:mainfrom
scbizu:fix/multi-tenant-object-path
Mar 10, 2021
Merged

pkg/chartmuseum/server: fix chart object path invalid#423
jdolitsky merged 2 commits into
helm:mainfrom
scbizu:fix/multi-tenant-object-path

Conversation

@scbizu

@scbizu scbizu commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Fix #421

  • Fix invalid path
  • Cover tests with multi-tenant server

…efix) in multi-tenant server and fix helm#421.

Signed-off-by: scnace <[email protected]>
@scbizu
scbizu force-pushed the fix/multi-tenant-object-path branch from 38db478 to 6990830 Compare February 23, 2021 17:42
@scbizu scbizu changed the title pkg/chartmuseum/server: fix chart object path invalid [WIP] pkg/chartmuseum/server: fix chart object path invalid Feb 24, 2021
@scbizu scbizu changed the title [WIP] pkg/chartmuseum/server: fix chart object path invalid pkg/chartmuseum/server: fix chart object path invalid Feb 24, 2021
@scbizu scbizu self-assigned this Feb 24, 2021
@scbizu
scbizu marked this pull request as draft February 24, 2021 02:27
@helm-bot helm-bot added size/M and removed size/XS labels Feb 27, 2021
@scbizu
scbizu force-pushed the fix/multi-tenant-object-path branch 2 times, most recently from 4226b34 to a63a9a1 Compare February 27, 2021 10:36
@scbizu
scbizu requested a review from jdolitsky February 27, 2021 10:44
@scbizu
scbizu force-pushed the fix/multi-tenant-object-path branch from a63a9a1 to 3f6815e Compare February 27, 2021 11:06
@scbizu
scbizu force-pushed the fix/multi-tenant-object-path branch from 3f6815e to b1d0cf4 Compare February 27, 2021 11:14
@scbizu
scbizu marked this pull request as ready for review February 27, 2021 11:36

@jdolitsky jdolitsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - merge when ready

@scbizu

scbizu commented Mar 7, 2021

Copy link
Copy Markdown
Contributor Author

Can we merge it now ? And release the v0.13.1 version or port it to 0.14.0 ? @jdolitsky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multi-tenant server is broken with local storage in v0.13.0

3 participants