ci: migrate release from docker hub into github container registry#395
Merged
Conversation
2 tasks
Signed-off-by: scnace <[email protected]>
scbizu
force-pushed
the
feature/release-migration
branch
from
November 29, 2020 11:22
cbc85d1 to
30001aa
Compare
jdolitsky
requested changes
Nov 30, 2020
jdolitsky
left a comment
jdolitsky
left a comment
Contributor
There was a problem hiding this comment.
I'm not sure we need personal access token.. but we can remove later
Comment on lines
+3
to
+6
| on: | ||
| pull_request: | ||
| branches: | ||
| - main |
Contributor
There was a problem hiding this comment.
Switch to build on push to main:
on:
push:
branches: main
tags:
- v*
GitHub actions will not use your the repo secrets on pull request, so we will just need to merge it to test
jdolitsky
reviewed
Nov 30, 2020
| - name: Prepare | ||
| id: prepare | ||
| run: | | ||
| DOCKER_IMAGE=chartmuseum/chartmuseum |
Contributor
There was a problem hiding this comment.
I think the issue is this probably needs to be ghcr.io/helm/chartmuseum
Signed-off-by: scnace <[email protected]>
scbizu
force-pushed
the
feature/release-migration
branch
from
November 30, 2020 15:37
69f2c25 to
1f5d700
Compare
jdolitsky
approved these changes
Nov 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: scnace [email protected]
Per #391