Skip to content

Support "preview" release CI runs#3757

Merged
the-mikedavis merged 2 commits into
helix-editor:masterfrom
yvt:patch/ci-release-draft
Sep 10, 2022
Merged

Support "preview" release CI runs#3757
the-mikedavis merged 2 commits into
helix-editor:masterfrom
yvt:patch/ci-release-draft

Conversation

@yvt

@yvt yvt commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

Expands the trigger sources of the release CI workflow (release.yml), allowing the developers to test changes to .github/workflows/release.yml easily. The new trigger sources start the workflow in a preview mode, in which it publishes build outputs as a CI artifact (example) instead of creating a new release so that they can be manually inspected.

The following events trigger the preview mode:

  • Pushing to any branch matching the glob pattern patch/ci-release-*.
  • Opening a pull request that modifies .github/workflows/release.yml.
  • Pushing versioning tags to a forked repository (they would create a release otherwise).

Comment thread .github/workflows/release.yml Outdated
@the-mikedavis

the-mikedavis commented Sep 9, 2022

Copy link
Copy Markdown
Member

This is quite cool, thanks for working on it 😀

I was a bit worried that it would publish draft releases which could be noisy for watchers but just uploading the artifacts is a good solution 👍

yvt and others added 2 commits September 10, 2022 13:14
Expands the trigger sources of the release CI workflow (`release.yml`),
allowing the developers to test changes to `.github/workflows/release.yml`
easily. The new trigger sources start the workflow in a "preview" mode, in
which it publishes build outputs as a CI artifact instead of creating a new
release so that they can be manually inspected.

The following events trigger the preview mode:

- Pushing to any branch matching the glob pattern `patch/ci-release-*`.
- Opening a pull request that modifies `.github/workflows/release.yml`.
- Pushing versioning tags to a forked repository.
@yvt
yvt force-pushed the patch/ci-release-draft branch from 29ec3d1 to ad37184 Compare September 10, 2022 04:16
@yvt yvt changed the title Support "draft" release CI runs Support "preview" release CI runs Sep 10, 2022
@yvt
yvt requested a review from the-mikedavis September 10, 2022 07:04
@the-mikedavis
the-mikedavis merged commit 02d6102 into helix-editor:master Sep 10, 2022
@yvt
yvt deleted the patch/ci-release-draft branch September 10, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants