Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook-count is zero, but facebook debugger returns 30 #127

Closed
ahoiroman opened this issue Oct 27, 2017 · 11 comments
Closed

Facebook-count is zero, but facebook debugger returns 30 #127

ahoiroman opened this issue Oct 27, 2017 · 11 comments

Comments

@ahoiroman
Copy link

Hi there,

am using the backend for quite a while now.

But unfortunately the facebook-count always shows 0.

This is my config:

array(4) {
  ["cache"]=>
  array(2) {
    ["ttl"]=>
    int(5)
    ["cacheDir"]=>
    string(38) "/var/www/domain.org/tmp/cache"
  }
  ["domains"]=>
  array(1) {
    [0]=>
    string(22) "domain.org"
  }
  ["services"]=>
  array(2) {
    [0]=>
    string(8) "Facebook"
    [1]=>
    string(10) "GooglePlus"
  }
  ["Facebook"]=>
  array(2) {
    ["app_id"]=>
    string(15) "my-id"
    ["secret"]=>
    string(32) "my-secret"
  }
}

This is the result:
{"facebook":0,"googleplus":0}

But it should be 30?
@ahoiroman
Copy link
Author

Problem can be solved by changing:

heise/shariff/src/Backend/Facebook.php

Replace in function getRequest

$query = 'https://graph.facebook.com/v2.8/?id='.urlencode($url).'&access_token='.$accessToken;

with

$query = 'https://graph.facebook.com/v2.10/?id='.urlencode($url).'&fields=og_object{engagement}&access_token='.$accessToken;

And in function extractCount

Add

if (isset($data['og_object']['engagement']['count'])) {

return $data['og_object']['engagement']['count'];
}
return 0;
}

@liayn
Copy link
Contributor

liayn commented Nov 1, 2017

This seems to be an issue with the settings of your facebook user. AFAIK you can set the minimum API version per user. I suppose your's is 2.10
The current code works flawlessly for us on various live sites

@ahoiroman
Copy link
Author

If you create a new Facebook App, you can not set an API-version < 2.10 .

So the current code does only work if you created your app a while ago.

@liayn
Copy link
Contributor

liayn commented Nov 2, 2017

Alright. Thanks for figuring that out. Time to update the code then.
Can you please push your suggested change as a pull request to speed up things?

@richard67
Copy link
Contributor

Pull request see #128. Please test.

@richard67 richard67 mentioned this issue Nov 6, 2017
Merged
@ahoiroman
Copy link
Author

Works for me :)

@ahoiroman
Copy link
Author

Any idea, when this will be merged? My users (I created a little extension for Pagekit CMS) are waiting for this :)

@richard67
Copy link
Contributor

@SPQRInc Maybe ask here: #128.

@ahoiroman
Copy link
Author

Great, it has been merged :)

Now I'm just waiting for a release of version 7.1, which includes the bugfix :)

@richard67
Copy link
Contributor

@SPQRInc No need to wait, 7.0.1 is out.

@compeak
Copy link
Collaborator

compeak commented Nov 21, 2017

This should be fixed in 7.0.1.

@compeak compeak closed this as completed Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liayn @compeak @richard67 @ahoiroman