Make InternalsVisibleTo instead of public#3
Closed
panopticoncentral wants to merge 1 commit intoheejaechang:oopfrom
panopticoncentral:oop
Closed
Make InternalsVisibleTo instead of public#3panopticoncentral wants to merge 1 commit intoheejaechang:oopfrom panopticoncentral:oop
panopticoncentral wants to merge 1 commit intoheejaechang:oopfrom
panopticoncentral:oop
Conversation
Owner
|
@panopticoncentral compiler layer can't have internal visible to workspace layer. so we can't have that attribute in compiler layer. @CyrusNajmabadi I already talked to @jaredpar about making get checksum API public. probably need to change shape of API, but he was okay making some shape of get checksum API public. |
|
Correct. Let's try and make this public vs. IVT. IIRC the last time we looked at this API the major problem was the |
Author
|
Great, thanks for explaining, helpful to understand how IVT is used in Roslyn! |
heejaechang
added a commit
that referenced
this pull request
Aug 15, 2017
#1. made persisted storage exclusive to 1 process. like before, second VS with same solution will not use persisted storage. #2, tweaked sqlite to share cache between connections like esent. #3, made VS and OOP to use different db files (we can make them to share if we want to, but for now, nobody requires it so we create 2 different db) .. made OOP mock to enable persisted service.
heejaechang
pushed a commit
that referenced
this pull request
Apr 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@heejaechang Does this address Cyrus's comment about making the GetChecksum API public?