cmake: Fix searching for sys/sdt.h in depends
#37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
pablomartin4btc
approved these changes
Oct 22, 2023
pablomartin4btc
left a comment
pablomartin4btc
left a comment
There was a problem hiding this comment.
tACK
Followed debian with depends instructions on ubuntu 22.04.
fanquake
added a commit
to bitcoin-core/gui
that referenced
this pull request
Oct 23, 2023
… explicitly in `util/trace.h` 6bdff42 build: Include `config/bitcoin-config.h` explicitly in `util/trace.h` (Hennadii Stepanov) Pull request description: The `ENABLE_TRACING` macro is expected to be defined in the `config/bitcoin-config.h` header. Therefore, the current code is error-prone as it depends on whether the `config/bitcoin-config.h` header was included before or not. This bug was noticed while working on CMake [stuff](hebasto/bitcoin#37). ACKs for top commit: fanquake: ACK 6bdff42 Tree-SHA512: 22c4fdeb51628814050eb99a83db4268a4f3106207eeef918a07214bbc52f2b22490f6b05fcb96216f147afa4197c51102503738131e2583e750b6d195747a49
sedited
reviewed
Oct 24, 2023
| include(CMakePushCheckState) | ||
| cmake_push_check_state(RESET) | ||
| set(CMAKE_REQUIRED_INCLUDES ${SystemTap_INCLUDE_DIR}) | ||
| include(CheckCXXSourceCompiles) |
hebasto
force-pushed
the
231020-cmake-N
branch
from
c7768b9 to
ab82110
Compare
|
ACK ab82110 |
sedited
approved these changes
Oct 24, 2023
Frank-GER
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Nov 28, 2023
…tly in `util/trace.h` 6bdff42 build: Include `config/bitcoin-config.h` explicitly in `util/trace.h` (Hennadii Stepanov) Pull request description: The `ENABLE_TRACING` macro is expected to be defined in the `config/bitcoin-config.h` header. Therefore, the current code is error-prone as it depends on whether the `config/bitcoin-config.h` header was included before or not. This bug was noticed while working on CMake [stuff](hebasto#37). ACKs for top commit: fanquake: ACK 6bdff42 Tree-SHA512: 22c4fdeb51628814050eb99a83db4268a4f3106207eeef918a07214bbc52f2b22490f6b05fcb96216f147afa4197c51102503738131e2583e750b6d195747a49
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 24, 2024
…tly in `util/trace.h` 6bdff42 build: Include `config/bitcoin-config.h` explicitly in `util/trace.h` (Hennadii Stepanov) Pull request description: The `ENABLE_TRACING` macro is expected to be defined in the `config/bitcoin-config.h` header. Therefore, the current code is error-prone as it depends on whether the `config/bitcoin-config.h` header was included before or not. This bug was noticed while working on CMake [stuff](hebasto#37). ACKs for top commit: fanquake: ACK 6bdff42 Tree-SHA512: 22c4fdeb51628814050eb99a83db4268a4f3106207eeef918a07214bbc52f2b22490f6b05fcb96216f147afa4197c51102503738131e2583e750b6d195747a49
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was noticed during testing the #31.