Skip to content

cmake: Port PR30235 from the master branch #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hebasto merged 2 commits into from
Jun 10, 2024
Merged

cmake: Port PR30235 from the master branch #227

hebasto merged 2 commits into from
Jun 10, 2024

Conversation

@hebasto
Copy link
Owner

@hebasto hebasto commented Jun 10, 2024

This PR ports bitcoin#30235.

theuni and others added 2 commits June 10, 2024 09:45
@theuni @hebasto
refactor: disable self-assign warning for tests
bb12261 
clang-16 and earlier detect "foo -= foo" and "foo /= foo" as self-assignments.
@hebasto
fixup! cmake: Add compiler diagnostic flags
160fd92 
Port PR30235.
@hebasto hebasto mentioned this pull request Jun 10, 2024
Merged
@hebasto hebasto added the port from autotools Ported from the main repository label Jun 10, 2024
maflcko
maflcko approved these changes Jun 10, 2024
View reviewed changes
Copy link

@maflcko maflcko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hebasto hebasto merged commit 0007a17 into cmake-staging Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maflcko maflcko maflcko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

port from autotools Ported from the main repository

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hebasto @maflcko @theuni