cmake: Regular rebasing of the cmake-staging branch
#202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a sanity check for non-encapsulated (directory-wide) build properties.
Co-authored-by: Cory Fields <[email protected]> Co-authored-by: Vasil Dimov <[email protected]>
Co-authored-by: Cory Fields <[email protected]>
If any of {C,CXX,CPP,LD}FLAGS is specified it should be assigned to
a non-type-specific variable.
To configure CMake for cross-compiling, use
`--toolchain depends/${HOST}/toolchain.cmake` command-line option.
`WITH_BDB` default is `OFF`.
Also docs and CI scripts have been updated.
Only versioning has been updated for now.
For more details, see bitcoin#30096.
The content of those variables is appended to the each target flags added by the build system.
Keep this commit at the top when rebasing.
Owner
Author
|
For the master branch CI, please refer to bitcoin#29790 (comment): |
This was referenced May 20, 2024
Owner
Author
|
My Guix build: |
|
Guix build (aarch64): |
Owner
Author
|
Thank you for your review! This branch has been force pushed into the https://github.com/hebasto/bitcoin/tree/cmake-staging. Closing. |
hebasto
added a commit
that referenced
this pull request
May 21, 2024
ecd3894 fixup! cmake: Add `config/bitcoin-config.h` support (Hennadii Stepanov) Pull request description: This PR ports bitcoin#29494 after the recent sync/rebase [PR](#202). Top commit has no ACKs. Tree-SHA512: e2a7f7132dfdb5653878d33c37675410b313097207bee090f82ed817448ed1a2eb48c146818af4d288eb5ff3d51fd64db561e5d3fe8eec433e8ff6f0812c0469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cmake-staging branch rebased on the recent bitcoin/master one, which includes the main build system changes, with the squashed "!fixup" commits.
Steps to reproduce:
There are a few conflicts that have to be resolved.
Squash the "FIXUP" commits manually (it must be a zero-diff change).
Reorder the recent commits to pop up the docs and CI changes (it must be a zero-diff change).
Port build system changes from: