Repository navigation
Commit d8b7a39
committed
Python: fix(core): close ResponseStream iterators on abort and hook errors
The Copilot review on #8773 was right: binding the SDK stream with
`async with` only unwinds when the wrapping generator is closed, and
nothing closed it when a consumer broke out of the loop or a transform
hook raised after a yielded update. ResponseStream is now an async
context manager whose __aexit__ closes the stream, and __anext__ closes
the active iterator when a map/flat_map transform or a transform hook
raises, so the provider stream is released on both paths instead of
waiting for GC.
Signed-off-by: Yufeng He <[email protected]>1 parent aa46520 commit d8b7a39
3 files changed
Lines changed: 82 additions & 4 deletions
File tree
- python/packages
- core
- agent_framework
- tests/core
- openai/tests/openai
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3722 | 3722 | | |
3723 | 3723 | | |
3724 | 3724 | | |
| 3725 | + | |
| 3726 | + | |
| 3727 | + | |
| 3728 | + | |
| 3729 | + | |
| 3730 | + | |
| 3731 | + | |
3725 | 3732 | | |
3726 | 3733 | | |
3727 | 3734 | | |
| |||
4005 | 4012 | | |
4006 | 4013 | | |
4007 | 4014 | | |
| 4015 | + | |
4008 | 4016 | | |
4009 | 4017 | | |
4010 | | - | |
4011 | 4018 | | |
4012 | 4019 | | |
4013 | 4020 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
4493 | 4493 | | |
4494 | 4494 | | |
4495 | 4495 | | |
| 4496 | + | |
| 4497 | + | |
| 4498 | + | |
| 4499 | + | |
| 4500 | + | |
| 4501 | + | |
| 4502 | + | |
| 4503 | + | |
| 4504 | + | |
| 4505 | + | |
| 4506 | + | |
| 4507 | + | |
| 4508 | + | |
| 4509 | + | |
| 4510 | + | |
| 4511 | + | |
| 4512 | + | |
| 4513 | + | |
| 4514 | + | |
| 4515 | + | |
| 4516 | + | |
| 4517 | + | |
| 4518 | + | |
| 4519 | + | |
| 4520 | + | |
| 4521 | + | |
| 4522 | + | |
| 4523 | + | |
| 4524 | + | |
| 4525 | + | |
| 4526 | + | |
| 4527 | + | |
| 4528 | + | |
| 4529 | + | |
| 4530 | + | |
| 4531 | + | |
| 4532 | + | |
| 4533 | + | |
| 4534 | + | |
| 4535 | + | |
| 4536 | + | |
| 4537 | + | |
| 4538 | + | |
| 4539 | + | |
| 4540 | + | |
4496 | 4541 | | |
4497 | 4542 | | |
4498 | 4543 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2215 | 2215 | | |
2216 | 2216 | | |
2217 | 2217 | | |
2218 | | - | |
2219 | | - | |
2220 | | - | |
| 2218 | + | |
| 2219 | + | |
| 2220 | + | |
| 2221 | + | |
| 2222 | + | |
| 2223 | + | |
| 2224 | + | |
| 2225 | + | |
| 2226 | + | |
| 2227 | + | |
| 2228 | + | |
| 2229 | + | |
| 2230 | + | |
| 2231 | + | |
| 2232 | + | |
| 2233 | + | |
| 2234 | + | |
| 2235 | + | |
| 2236 | + | |
| 2237 | + | |
| 2238 | + | |
| 2239 | + | |
| 2240 | + | |
| 2241 | + | |
| 2242 | + | |
| 2243 | + | |
| 2244 | + | |
| 2245 | + | |
| 2246 | + | |
2221 | 2247 | | |
2222 | 2248 | | |
2223 | 2249 | | |
| |||
0 commit comments