Skip to content

feat: allow highlighting the images and display them in parent section#97

Merged
razonyang merged 1 commit intomainfrom
highlight-images
Jan 3, 2024
Merged

feat: allow highlighting the images and display them in parent section#97
razonyang merged 1 commit intomainfrom
highlight-images

Conversation

@razonyang
Copy link
Copy Markdown
Member

Closes #96

To highlight an image.

// content/gallery/foo/index.md
resources:
  - src: foo.jpg
    params:
      highlight: true

To limit the number of highlighting images.

// params.yaml
hb:
  gallery:
    highlight_images_count: 10

@pleasantone
Copy link
Copy Markdown
Contributor

pleasantone commented Jan 3, 2024

Your version behaves differently than mine.
Using the tree hierarchy I used: Gallery>2023 President's Day>day1
The highlight images show up in both Gallery and Gallery>2023 President's Day.
I think they should only pop up one level.

I think RegularPagesRecursive should be replaced by RegularPages.

@razonyang
Copy link
Copy Markdown
Member Author

Should be fixed by d2b8a01.

@pleasantone
Copy link
Copy Markdown
Contributor

Confirmed! Works perfectly, thanks.

@pleasantone
Copy link
Copy Markdown
Contributor

...while it works, there is one possible enhancement that would be nice... I'm trying to decode how to do it but you're probably faster. It would be nice if the highlight photos that show up are in their own bigger-picture virtual album and that one could navigate through them (e.g. front and back)( (and just them, not the albums) as if they were their own album.

@razonyang
Copy link
Copy Markdown
Member Author

razonyang commented Jan 3, 2024

It would be nice if the highlight photos that show up are in their own bigger-picture virtual album and that one could navigate through them (e.g. front and back)( (and just them, not the albums) as if they were their own album.

I created a PR for this, we need separate highlight images from albums, please tweak that PR (checkout -b and create a new PR for that branch style-separate-highlight-images) if you've a better UI idea.

@razonyang
Copy link
Copy Markdown
Member Author

I forgot to link the PR, it's #100.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants