Skip to content

Implementation Provided for Reflection Access to idleTimeMillis() Method at Runtime in Native Image Creation #26387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
omercelikceng wants to merge 1 commit into from
Closed

Implementation Provided for Reflection Access to idleTimeMillis() Method at Runtime in Native Image Creation #26387

omercelikceng wants to merge 1 commit into from

Conversation

@omercelikceng
Copy link
Contributor

@omercelikceng omercelikceng commented Jul 30, 2024 •
edited
Loading

In my Spring Boot project, I am using Hazelcast version 5.0.0.
I am able to create a native image successfully. However, when I run the application, I get the following error at runtime.
This error does not cause the application to shut down.

I reviewed the code. A method is invoked using reflection, but the method is not registered in the hints, so the error occurs.
Method is private long com.hazelcast.internal.networking.nio.NioOutboundPipeline.idleTimeMillis().
I resolved the issue by adding this method to the hints.

Here is a sample project where you can reproduce the error. After cloning the project, follow the steps in the README.md file on the main branch, and you will see the error occur. Switch to the solution branch and follow the steps in the README.md file there, and you will see that the error is resolved. You will see that the service does not throw any errors and running correctly. The relevant code fixes have been made in the solution branch.

By following the steps in the README file, you will see the error occurring in the code on the main branch and observe that it is resolved in the code on the solution branch. I’ve made it easier for you. Thank you.

The branch link where you can reproduce the error : https://github.com/omercelikceng/native-poc-cache-issue/tree/main
The branch link where the error is resolved : https://github.com/omercelikceng/native-poc-cache-issue/tree/solution

Error :

2024-07-30T13:38:51.976Z  WARN 1 --- [nt_1.internal-2] c.h.i.m.impl.MetricsCollectionCycle      : Collecting metrics from source com.hazelcast.internal.networking.nio.NioNetworking failed

org.graalvm.nativeimage.MissingReflectionRegistrationError: The program tried to reflectively invoke method private long com.hazelcast.internal.networking.nio.NioOutboundPipeline.idleTimeMillis() without it being registered for runtime reflection. Add private long com.hazelcast.internal.networking.nio.NioOutboundPipeline.idleTimeMillis() to the reflection metadata to solve this problem. See https://www.graalvm.org/latest/reference-manual/native-image/metadata/#reflection for help.
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.reflect.MissingReflectionRegistrationUtils.forQueriedOnlyExecutable(MissingReflectionRegistrationUtils.java:72) ~[na:na]
        at [email protected]/java.lang.reflect.Method.acquireMethodAccessor(Method.java:77) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.lang.reflect.Method.invoke(Method.java:577) ~[com.example.NativePocCacheApplication:na]
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.methodhandles.Util_java_lang_invoke_MethodHandle.invokeInternal(Target_java_lang_invoke_MethodHandle.java:265) ~[na:na]
        at [email protected]/java.lang.invoke.MethodHandle.invokeBasic(MethodHandle.java:98) ~[com.example.NativePocCacheApplication:na]
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.methodhandles.MethodHandleIntrinsicImpl.execute(MethodHandleIntrinsicImpl.java:179) ~[na:na]
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.methodhandles.Util_java_lang_invoke_MethodHandle.invokeInternal(Target_java_lang_invoke_MethodHandle.java:186) ~[na:na]
        at [email protected]/java.lang.invoke.MethodHandle.invokeBasic(MethodHandle.java:98) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.lang.invoke.LambdaForm$NamedFunction.invokeWithArguments(LambdaForm.java:96) ~[na:na]
        at [email protected]/java.lang.invoke.LambdaForm.interpretName(LambdaForm.java:959) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.lang.invoke.LambdaForm.interpretWithArguments(LambdaForm.java:936) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.lang.invoke.MethodHandle.invokeBasic(MethodHandle.java:105) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.lang.invoke.MethodHandle.invokeBasic(MethodHandle.java:0) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.lang.invoke.LambdaForm$MH/0x00000007c16b4800.invokeExact_MT(LambdaForm$MH) ~[na:na]
        at com.hazelcast.internal.metrics.impl.MethodProbe$LongMethodProbe.get(MethodProbe.java:197) ~[na:na]
        at com.hazelcast.internal.metrics.impl.MetricsCollectionCycle.collectLong(MetricsCollectionCycle.java:175) ~[na:na]
        at com.hazelcast.internal.metrics.impl.MetricsCollectionCycle.collect(MetricsCollectionCycle.java:153) ~[na:na]
        at com.hazelcast.internal.metrics.impl.MetricsCollectionCycle.extractAndCollectDynamicMetrics(MetricsCollectionCycle.java:128) ~[na:na]
        at com.hazelcast.internal.metrics.impl.MetricsCollectionCycle$MetricsContext.collect(MetricsCollectionCycle.java:189) ~[na:na]
        at com.hazelcast.internal.networking.nio.NioNetworking.provideDynamicMetrics(NioNetworking.java:371) ~[com.example.NativePocCacheApplication:5.5.0]
        at com.hazelcast.internal.metrics.impl.MetricsCollectionCycle.collectDynamicMetrics(MetricsCollectionCycle.java:94) ~[na:na]
        at com.hazelcast.internal.metrics.impl.MetricsRegistryImpl.collect(MetricsRegistryImpl.java:320) ~[na:na]
        at com.hazelcast.client.impl.statistics.ClientStatisticsService.collectAndSendStats(ClientStatisticsService.java:148) ~[na:na]
        at [email protected]/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:572) ~[na:na]
        at [email protected]/java.util.concurrent.FutureTask.runAndReset(FutureTask.java:358) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:305) ~[na:na]
        at [email protected]/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642) ~[na:na]
        at [email protected]/java.lang.Thread.runWith(Thread.java:1596) ~[com.example.NativePocCacheApplication:na]
        at [email protected]/java.lang.Thread.run(Thread.java:1583) ~[com.example.NativePocCacheApplication:na]
        at com.hazelcast.internal.util.executor.HazelcastManagedThread.executeRun(HazelcastManagedThread.java:76) ~[com.example.NativePocCacheApplication:5.5.0]
        at com.hazelcast.internal.util.executor.PoolExecutorThreadFactory$ManagedThread.executeRun(PoolExecutorThreadFactory.java:74) ~[na:na]
        at com.hazelcast.internal.util.executor.HazelcastManagedThread.run(HazelcastManagedThread.java:111) ~[com.example.NativePocCacheApplication:5.5.0]
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.thread.PlatformThreads.threadStartRoutine(PlatformThreads.java:838) ~[com.example.NativePocCacheApplication:na]
        at org.graalvm.nativeimage.builder/com.oracle.svm.core.posix.thread.PosixPlatformThreads.pthreadStartRoutine(PosixPlatformThreads.java:211) ~[na:na]

@hz-devops-test hz-devops-test added the Source: Community PR or issue was opened by a community user label Jul 30, 2024
@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Jul 30, 2024

Can one of the admins verify this patch?

@devOpsHazelcast
Copy link
Collaborator

devOpsHazelcast commented Jul 30, 2024

Internal PR hazelcast/hazelcast-mono#2807
Internal message only. Nothing to see here, move along

@omercelikceng omercelikceng mentioned this pull request Aug 1, 2024
Closed
@omercelikceng omercelikceng force-pushed the metricRegistrationToHint branch from f1a6311 to 5a456e5 Compare August 7, 2024 18:09
@omercelikceng omercelikceng force-pushed the metricRegistrationToHint branch from 5a456e5 to 3e3b4bc Compare August 21, 2024 08:49
@omercelikceng
When the native image is created, an implementation was provided to e…
702bac6 
…nable access to the idleTimeMillis() method through reflection at runtime.
@omercelikceng omercelikceng force-pushed the metricRegistrationToHint branch from 3e3b4bc to 702bac6 Compare August 21, 2024 12:59
@kwart
Copy link
Contributor

kwart commented Aug 26, 2024

Thank you for your contribution!

As far as I know, Hazelcast doesn't officially support GraalVM at this time. There is some limited client support for Quarkus, but it remains outside of official product backing.

That said, there is existing metadata for Hazelcast in the graalvm-reachability-metadata repository. Currently, these metadata files cover Hazelcast version 5.2.1, and they might be adaptable for other 5.y.z versions.

Given that official GraalVM support is pending any decision from Hazelcast product management, I would recommend closing this PR for now. Should official support be established in the future, more comprehensive work will be needed beyond metadata files, such as adding thorough test coverage.

Thank you again for your effort and understanding!

@omercelikceng
Copy link
Contributor Author

omercelikceng commented Aug 26, 2024

@kwart Actually, I support many open source projects. I could solve any errors or issues that arise in this context. Additionally, I have already conducted comprehensive testing on Hazelcast. However, I understand your points. I am closing the pull request. Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Source: Community PR or issue was opened by a community user

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@omercelikceng @devOpsHazelcast @kwart @hz-devops-test