Skip to content

Update golang to 1.17 and dependencies #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hazcod merged 5 commits into from
Jan 16, 2022
Merged

Update golang to 1.17 and dependencies #112

hazcod merged 5 commits into from
Jan 16, 2022

Conversation

@msladek
Copy link
Contributor

@msladek msladek commented Jan 16, 2022 •
edited
Loading

  1. ran
go mod edit -go=1.17 && \
go get all && \
go mod tidy
  1. updated golang to 1.17
  • in Makefile
  • in .github/go/Dockerfile
  1. removed vendor from .gitignore
    removed vendor dir

@msladek msladek mentioned this pull request Jan 16, 2022
Merged
@hazcod
Copy link
Owner

hazcod commented Jan 16, 2022

@msladek FYI it's now a common practice to not rely on vendor/ anymore but the local go mod cache.
Hence me removing it from git a couple of months ago.

@msladek
Copy link
Contributor Author

msladek commented Jan 16, 2022

@hazcod I see, but why then is there still a vendor dir on the master branch? shouldn't it be removed from the repo?

@hazcod hazcod merged commit 6a0861d into hazcod:master Jan 16, 2022
@hazcod
Copy link
Owner

hazcod commented Jan 16, 2022

@msladek Fair point, not sure where I forgot to push. Thanks!

@msladek msladek deleted the update branch January 16, 2022 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@msladek @hazcod