Repository navigation
Avoid spacing for icon-only smart paste buttons - #1761
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes #1682 by preventing non-breaking-space separators on icon-only smart paste buttons.
Changes:
- Uses caller-provided child content when deciding whether to render spacing.
- Covers start/end icon placement, text, child content, and repeated renders.
- References the Smart component project from Bootstrap tests.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Havit.Blazor.Components.Web.Bootstrap.Smart/HxSmartPasteButton.cs |
Corrects spacer conditions. |
Havit.Blazor.Components.Web.Bootstrap.Tests/Buttons/HxSmartPasteButtonTests.cs |
Adds regression coverage. |
Havit.Blazor.Components.Web.Bootstrap.Tests/Havit.Blazor.Components.Web.Bootstrap.Tests.csproj |
Adds the Smart project reference. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…Web.Bootstrap.Smart.Tests project Co-Authored-By: Claude Fable 5 <[email protected]>
Member
|
@snowyukitty Many thanx for your contribution! 🩷 |
hakenr
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1682
Summary
Validation
net10.0(0 warnings, 0 errors under WSL)Havit.Blazor.slnxbuild (0 warnings, 0 errors under WSL)git diff --check