Fix arguments for sourced script#147
Merged
frenck merged 1 commit intohassio-addons:mainfrom Dec 8, 2023
Merged
Conversation
Shifts around the arguments and updates $0 so that they would be as you expect if the script was exec'd instead of source'd
frenck
approved these changes
Dec 8, 2023
Member
frenck
left a comment
There was a problem hiding this comment.
Makes a lot of sense, thanks, @baod-rate 👍
../Frenck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quality of life improvement for handling arguments, mostly useful for testing things on the command line.
Proposed Changes
Shifts around the arguments (and sets argv[0] to the target script) so that they would be as you expect if the call at the end of
bashiowasexec "$@"instead ofsource "$@".From the bash manual:
This makes handling arguments annoying, because there's no way other than testing
[[ $1 = $EXPECTED_SCRIPT_PATH ]]to see if arguments were passed on the command line. And if arguments are passed, there's no way to access the true script's pathExample
given
example.sh:prior to change:
after change: