Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: haskell-unordered-containers/unordered-containers
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.2.20
Choose a base ref
...
head repository: haskell-unordered-containers/unordered-containers
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.2.20.1
Choose a head ref
  • 9 commits
  • 16 files changed
  • 4 contributors

Commits on May 11, 2025

  1. Make CI work again and bump to 9.12.2 (#499)

    * Bump CI to GHC 9.12.2 and ubuntu-24.04 (needed)
    
    * Relax bounds for GHC 9.12 (needed)
    andreasabel authored May 11, 2025
    Configuration menu
    Copy the full SHA
    37eee22 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2025

  1. Remove bad isSubmapOf testcase (#504)

    The property tested is covered by the test case above, but
    the property claimed in the test name is plain wrong:
    
       m1 ⊈ m2  ⇒  m1 ∪ m2 ⊈ m1:          FAIL
         *** Failed! Falsified (after 1 test and 2 shrinks):
         fromList [(K {hash = 0, _x = A},0)]
         fromList []
    sjakobi authored Sep 26, 2025
    Configuration menu
    Copy the full SHA
    fee3769 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e380a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2025

  1. Fix infinite loop in isSubmapOf[By] / isSubsetOf on 32-bit platfo…

    …rms (#501)
    
    The internal `submapBitmapIndexed` function used by these functions could enter an infinite loop while comparing two nodes `m1` and `m2` where `m2` contained a sub-node associated with the partial hash `0b11111`. In this case the high bit of the combined bitmap of `m1` and `m2`, `b1Orb2`, was `1`. After checking the submap condition at the high bit, the 32-bit `m` variable used to iterate over `b1Orb2` would be left-shifted and overflow to `0`, resulting in the infinite loop. 
    
    https://github.com/haskell-unordered-containers/unordered-containers/blob/37eee2290cab287c0947d1de20235a37ced63c94/Data/HashMap/Internal.hs#L1551-L1572
    
    To fix this bug and any similar issues related to a branching factor of 32, we return to a branching factor of 16 for 32-bit platforms. On 64-bit platforms the branching factors stays at 32.
    
    Fixes #491.
    sjakobi authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    0971ad5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    333ccb3 View commit details
    Browse the repository at this point in the history
  3. Fixes docs of Data.HashMap.Lazy.fromList: it takes O(n * log(n)) (#498)

    Fixes the incorrect documentation in Data.HashMap.Lazy.fromList
    / Data.HashMap.Internal.fromList: This takes linearithmic time
    rather than linear time, since we do n insertions, each of which
    takes (assuming no collisions!) log32(n) steps as per the documentation
    of insert.
    
    Fixes #309
    Qqwy authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    7c66911 View commit details
    Browse the repository at this point in the history
  4. Require hashable >= 1.4 (#506)

    Resolves #487.
    sjakobi authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    7310538 View commit details
    Browse the repository at this point in the history
  5. Add disclaimer to D.HS.toList (#507)

    ...and improve the disclaimer for D.HM.toList.
    
    Fixes #481.
    sjakobi authored Sep 29, 2025
    Configuration menu
    Copy the full SHA
    5cdf332 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2025

  1. Configuration menu
    Copy the full SHA
    64e342e View commit details
    Browse the repository at this point in the history
Loading