Skip to content

Support QuantifiedConstraints#427

Merged
DanBurton merged 6 commits intohaskell-suite:masterfrom
AshleyYakeley:Ashley
Nov 1, 2019
Merged

Support QuantifiedConstraints#427
DanBurton merged 6 commits intohaskell-suite:masterfrom
AshleyYakeley:Ashley

Conversation

@AshleyYakeley
Copy link
Contributor

I've simplified the Asst and PAsst types so that a context assertion is either a type, an implicit parameter, or a parenthesised assertion.

@ttuegel
Copy link

ttuegel commented Feb 18, 2019

Lack of support for QuantifiedConstraints is breaking tool support (such as stylish-haskell) for GHC 8.6. Is there any way I could help get this merged?

@mpickering
Copy link
Collaborator

I didn't see this PR. Looks reasonable to me but CI is failing.

@AshleyYakeley
Copy link
Contributor Author

Looks like some warnings on older GHCs, shouldn't be too hard.

@AshleyYakeley
Copy link
Contributor Author

Before I fix it, is it intended that haskell-src-exts support GHC versions as far back as 7.6? Note that 7.10 (which this PR works with) was released almost four years ago.

@mpickering
Copy link
Collaborator

I suppose 7.6 is quite old now but seeing as it wasn't much effort to keep supporting I didn't see any reason to remove it. It's probably fine to remove releases before 7.10.

@AshleyYakeley
Copy link
Contributor Author

OK, so that fixed GHC 7.8. On GHC 7.6, two tests cause stack overflow.

@konn
Copy link

konn commented Apr 15, 2019

Any update on this?

@awpr
Copy link

awpr commented Jun 12, 2019

Associating this with related issues #433 and #419.

@cpeikert
Copy link

This would be a very useful feature for me. Is there update on whether it can be merged?

@DanBurton DanBurton merged commit 231ca6a into haskell-suite:master Nov 1, 2019
@DanBurton
Copy link
Contributor

It can! It's been on my backlog for a while. I had a mergeable version of this (see #441) about a month ago. I went ahead and merged & released as haskell-src-exts-1.22.0.

I made a slight mistake with the release in that the full changelog updates for this release were not properly published. See the in-repo changelog for more complete details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants