WithResource combinator for Servant-managed resources#1630
Merged
tchoutri merged 2 commits intohaskell-servant:masterfrom Dec 29, 2022
Merged
WithResource combinator for Servant-managed resources#1630tchoutri merged 2 commits intohaskell-servant:masterfrom
tchoutri merged 2 commits intohaskell-servant:masterfrom
Conversation
Contributor
|
@andremarianiello Hi! Thank you for the PR. :) I see a couple of leftover TODOs, ping me when the PR is ready for review. |
andremarianiello
force-pushed
the
servant-with-resource
branch
from
4c44a10 to
26db6a8
Compare
Contributor
Author
|
@tchoutri Whoops, sorry about that! I have replaced the TODO with documentation. Should be ready for review now. |
|
|
||
| hoistServerWithContext _ pc nt s = hoistServerWithContext (Proxy @api) pc nt . s | ||
|
|
||
| route Proxy context d = route (Proxy @api) context (d `addParameterCheck` allocateResource) |
Contributor
Author
There was a problem hiding this comment.
This addParameterCheck feels a bit hacky to me because allocateResource is not actually doing a parameter check, but I don't know of a better way to incorporate this allocation into the underlying ResourceT. If using addParameterCheck this way is too egregious I am of course open to alternatives.
andremarianiello
force-pushed
the
servant-with-resource
branch
from
26db6a8 to
2a1f903
Compare
Contributor
Author
|
@tchoutri ready for review |
Contributor
Author
|
Do you have any idea what is causing the CI failures? I don't see how they are related to my changes and I cannot reproduce the failure locally. |
Contributor
Author
|
Lots of successes in the last run, but the failure looks like its caused by Any idea what's going on? |
Contributor
|
Yes, I'm going to disable the stack CI for the foreseeable future, it's no longer a good indicator of software quality. |
tchoutri
approved these changes
Dec 29, 2022
tchoutri
pushed a commit
to tchoutri/servant
that referenced
this pull request
Dec 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! This is the PR discussed in #1345 , cookbook included.